move render_errors to helper & update method set_lang

app/controllers/apply_job_controller.rb

@@ -21,9 +21,7 @@ class ApplyJobController < ApplicationController
     @apply_job.cv = current_user.cv if @apply_job.cv.blank?
     session[:cache_name] = @apply_job.cv.cache_name
     if @apply_job.invalid?
-      errors = []
-      @apply_job.errors.full_messages.each { |mess| errors << "#{mess}<br>" }
-      flash[:error] = errors.join('<br>').html_safe
+      helpers.render_errors(@apply_job)
       redirect_to apply_path(job_id: session[:job_id])
     end
   end

app/controllers/users_controller.rb

@@ -7,17 +7,12 @@ class UsersController < ApplicationController
     render :confirm
   end
 
-  def my_page
-  end
+  def my_page; end
 
   def set_lang
-    if user_signed_in?     
-      if params[:lang] == 'vi' || params[:lang] == 'en'       
-        User.update(current_user.id, language: params[:lang]) 
-        redirect_to '/' 
-      else 
-        redirect_to '/' 
-      end   
+    if user_signed_in? && current_user.language != params[:lang]
+      User.update(current_user.id, language: params[:lang]) if params[:lang] == 'vi' || params[:lang] == 'en'
     end
+    redirect_to '/'
   end
 end

app/helpers/apply_job_helper.rb

+#frozen_string_literal: true
+
 module ApplyJobHelper
+  def render_errors(obj)
+    errors = []
+    obj.errors.full_messages.each { |mess| errors << "#{mess}<br>" }
+    flash[:error] = errors.join('<br>').html_safe
+  end
 end