split job import file

Gemfile

@@ -25,7 +25,6 @@ gem 'sunspot_rails'
 gem 'sunspot_solr'
 gem 'devise'
 gem 'activerecord-import'
-gem 'pry'
 # Use Redis adapter to run Action Cable in production
 # gem 'redis', '~> 4.0'
 # Use Active Model has_secure_password
@@ -40,6 +39,7 @@ gem 'bootsnap', '>= 1.4.2', require: false
 group :development, :test do
   # Call 'byebug' anywhere in the code to stop execution and get a debugger console
   gem 'byebug', platforms: [:mri, :mingw, :x64_mingw]
+  gem 'pry'
 end
 
 group :development do

app/services/import.rb

@@ -5,23 +5,16 @@ class Import
     cities = []
     companies = []
     industries = []
-    jobs = []
 
     city_columns = [:name, :region]
     company_columns = [:name, :email, :address, :code]
     industry_columns = [:name]
-    job_columns = [:title, :level, :salary, :description, :short_des, :requirement,
-      :category, :company_id]
 
     CSV.foreach(Rails.root.join("lib", "jobss.csv"), headers: true) do |row|
       cities << {name: row["company province"], region: "Việt Nam"}
       companies << {name: row["company name"], email: row["contact email"],
         address: row["company address"], code: row["company id"]}
       industries << {name: row["category"]}
-      jobs << {title: row["name"], level: row["level"], salary: row["salary"],
-        description: row["description"], short_des: row["benefit"],
-        requirement: row["requirement"], category: row["type"],
-        company_id: Company.find_by(code: row["company id"])&.id}
     end
 
     City.import city_columns, cities, on_duplicate_key_ignore: true
@@ -32,8 +25,5 @@ class Import
 
     Industry.import industry_columns, industries, on_duplicate_key_ignore: true
     puts "Industries imported"
-
-    Job.import job_columns, jobs
-    puts "Jobs imported"
   end
 end

app/services/job_csv.rb

+class JobCsv
+  def initialize(row)
+    @row = row
+  end
+
+  def title
+    @title ||= @row["title"]
+  end
+
+  def level
+    @level ||= @row["level"]
+  end
+
+  def salary
+    @salary ||= @row["salary"]
+  end
+
+  def description
+    @description ||= @row["description"]
+  end
+
+  def short_des
+    @short_des ||= @row["benefit"]
+  end
+
+  def requirement
+    @requirement ||= @row["requirement"]
+  end
+
+  def category
+    @category ||= @row["type"]
+  end
+
+  def company_id
+    @company_id ||= company.id
+  end
+
+  def company
+    @company ||= Company.find_or_create_by(code: @row["company id"])
+  end
+
+  def csv_attributes
+    {title: self.title, level: self.level, salary: self.salary, description: self.description,
+     short_des: self.short_des, requirement: self.requirement, category: self.category,
+     company_id: self.company_id}
+  end
+end

app/services/jobs_import.rb

+require "csv"
+
+class JobsImport
+  def import_job
+    jobs = []
+    job_columns = [:title, :level, :salary, :description, :short_des,
+                   :requirement, :category, :company_id]
+
+    CSV.foreach(Rails.root.join("lib", "jobss.csv"), headers: true) do |row|
+      jobcsv = JobCsv.new(row)
+      jobs << jobcsv.csv_attributes
+    end
+
+    Job.import job_columns, jobs
+    puts "Jobs imported"
+  end
+end

app/views/cities/index.html.erb

-<table class="table">
-  <thead>
-    <tr>
-      <th scope="col">name</th>
-      <th scope="col">region</th>
-    </tr>
-  </thead>
-  <tbody>
-    <% @cities.each do |city| %>
-      <tr>
-        <td><%= city.name %></td>
-        <td><%= city.region %></td>
-      </tr>
-    <% end %>
-  </tbody>
-</table>
+<%= render partial: "cities/city", collection: @cities %>

app/views/industries/index.html.erb

-<table class="table">
-  <thead>
-    <tr>
-      <th scope="col">name</th>
-    </tr>
-  </thead>
-  <tbody>
-    <% @industries.each do |industry| %>
-      <tr>
-        <td><%= industry.name %></td>
-      </tr>
-    <% end %>
-  </tbody>
-</table>
+<%= render partial: "industries/industry", collection: @industries %>

app/views/jobs/index.html.erb

-<table class="table">
-  <thead>
-    <tr>
-      <th scope="col">title</th>
-      <th scope="col">short description</th>
-      <th scope="col">salary</th>
-    </tr>
-  </thead>
-  <tbody>
-    <% @jobs.each do |job| %>
-      <tr>
-        <td><%= job.title %></td>
-        <td><%= job.short_des %></td>
-        <td><%= job.salary %></td>
-      </tr>
-    <% end %>
-  </tbody>
-</table>
+<%= render partial: "jobs/job", collection: @jobs %>

lib/tasks/task.rake

-# require "./app/services/import.rb"
-
 namespace :task do
   desc "import data"
   task import: :environment do
     Import.new.import
+    JobsImport.new.import_job
   end
 end