Create Slug in City and Industry

app/assets/stylesheets/cities.scss

@@ -25,3 +25,4 @@
 .viet-nam, .international {
   cursor: pointer;
 }
+

app/assets/stylesheets/top_pages.scss

@@ -110,3 +110,16 @@
     }
   }
 }
+.result-for {
+  background-color: #99ff99;
+  border: 2px solid green;
+  border-radius: 12px;
+  text-align: center;
+}
+.total {
+  background-color: #b3ecff;
+  border: 2px solid #006080;
+  border-radius: 12px;
+  text-align: center;
+  font-size: 32px;
+}

app/common/convert.rb

+module Convert
+  def self.to_convert(str)
+    str.mb_chars.normalize(:kd).gsub(/[Đđ]/, 'd').gsub(/[^\x00-\x7F]/,'').gsub(/[\W+]/,' ').downcase.to_s.split(' ').join('-')
+  end
+
+  def self.to_convert_name(name)
+    name.mb_chars.normalize(:kd).gsub(/[Đđ]/, 'd').gsub(/[^\x00-\x7F]/,'').gsub(/[\W+0-9]/,' ').downcase.to_s.split(' ').join('-')
+  end
+end

app/controllers/jobs_controller.rb

 class JobsController < ApplicationController
+  before_action :use_variables
 
   def index
-    @cities = City.all
-    @industries = Industry.all
-    @total_job = Job.count
+
     @jobs_list = Job.all_job.page(params[:page]).per(20)
   end
 
   def city_jobs
-    @cities = City.all
-    @industries = Industry.all
-    @city = City.find_by(name: params[:name])
+    @city = City.find_by(converted_name: params[:converted_name])
     @jobs_list = @city.jobs.all_job.page(params[:page]).per(20)
-    @total_job = Job.count
     @result_for_job = @city.jobs.count
   end
 
   def industry_jobs
+    @industry = Industry.find_by(converted_name: params[:converted_name])
+    @jobs_list = @industry.jobs.all_job.page(params[:page]).per(20)
+    @result_for_job = @industry.jobs.count
+  end
+
+  def use_variables
     @cities = City.all
     @industries = Industry.all
-    @industry = Industry.find(params[:id])
-    @jobs_list = @industry.jobs.all_job.page(params[:page]).per(20)
     @total_job = Job.count
-    @result_for_job = @industry.jobs.count
   end
 end

app/models/city.rb

 class City < ApplicationRecord
+  before_save :convert_city
   has_many :city_jobs
   has_many :jobs, through: :city_jobs
 
@@ -6,7 +7,11 @@ class City < ApplicationRecord
   scope :vietnam, -> { joins(:jobs).group(:city_id).order('count(job_id) DESC').where('location = 1') }
   scope :international, -> { joins(:jobs).group(:city_id).order('count(job_id) DESC').where('location = 0') }
 
+  def convert_city
+    converted_name = Convert.to_convert("#{name}")
+  end
+
   def convert_name
-    name.mb_chars.normalize(:kd).gsub(/[Đđ]/, 'd').gsub(/[^\x00-\x7F]/,'').gsub(/[\W+0-9]/,' ').downcase.to_s.split(' ').join('-')
+    converted_name = Convert.to_convert_name("#{name}")
   end
 end

app/models/company.rb

 class Company < ApplicationRecord
+  before_save :convert_company
   has_many :jobs
+
+  def convert_company
+    self.converted_name = Convert.to_convert("#{name}")
+  end
 end

app/models/industry.rb

 class Industry < ApplicationRecord
+  before_save :convert_industry
   has_many :industry_jobs
   has_many :jobs, through: :industry_jobs
 
   scope :top_industry, -> { joins(:jobs).group(:industry_id).order('count(job_id) DESC').limit(9) }
   scope :all_industry, -> { joins(:jobs).group(:industry_id).order('count(job_id) DESC') }
 
+  def convert_industry
+    converted_name = Convert.to_convert("#{name}")
+  end
+
   def convert_name
-    name.mb_chars.normalize(:kd).gsub(/[Đđ]/, 'd').gsub(/[^\x00-\x7F]/,'').gsub(/[\W+0-9]/,' ').downcase.to_s.split(' ').join('-')
+    converted_name = Convert.to_convert_name("#{name}")
   end
 end

app/models/job.rb

 class Job < ApplicationRecord
+  before_save :convert_job
   belongs_to :company
   has_many :city_jobs
   has_many :cities, through: :city_jobs
@@ -18,6 +19,10 @@ class Job < ApplicationRecord
   scope :limit_job, -> { limit(5).order(created_at: :desc) }
   scope :all_job, -> { all.order(created_at: :desc) }
 
+  def convert_job
+    self.converted_name = Convert.to_convert("#{title}")
+  end
+
   def company_name
     company&.name
   end

app/views/cities/_cities_international.html.erb

 <div class="col-3 remove-decoration">
-  <%= link_to city_jobs_path(name: city.name) do %>
+  <%= link_to city_jobs_path(converted_name: city.converted_name) do %>
     <div class="border border-dark rounded vn-name">
       <div>
         <strong><%= city.name %></strong>

app/views/cities/_cities_vietnam.html.erb

 <div class="col-3 remove-decoration">
-  <%= link_to city_jobs_path(name: city.convert_name) do %>
+  <%= link_to city_jobs_path(converted_name: city.convert_name) do %>
     <div class="border border-dark rounded international-name">
       <div>
         <strong><%= city.name %></strong>

app/views/industries/_all_industries.html.erb

 <div class="col-3 remove-decoration">
-  <%= link_to industry_jobs_path(industry.id) do %>
+  <%= link_to industry_jobs_path(converted_name: industry.converted_name) do %>
     <div class="border border-dark rounded industry-details">
       <div>
         <strong><%= industry.name %></strong>

app/views/jobs/_all_jobs.html.erb

@@ -3,12 +3,10 @@
     <div class="job-details">
       <div class="title"><strong><%= job.title %></strong></div>
         <div class="row">
-          <div class="col-6">▼
-            <% job.cities.each do |city| %>
-              <%= city.name %>
-            <% end %>
+          <div class="col-5">▼
+            <%= job.cities.map(&:name).join(' | ') %>
           </div>
-          <div class="col-4 salary">💲 Salary: <%= job.salary %></div>
+          <div class="col-5 salary">💲 Salary: <%= job.salary %></div>
           <div class="col-10 introduction">
             <%= job_description(job.description) %><br>
             <%= link_to 'Read more..', '#'%>

app/views/jobs/_pagination.html.erb

-<div class="row">
+<div class="row panigation">
   <div class="col-12 d-flex justify-content-end paginate-jobs">
     <%= paginate @jobs_list, outer_window: 3, window: 2 %>
   </div>

app/views/jobs/city_jobs.html.erb

@@ -3,9 +3,8 @@
   <div class="search-bar">
     <%= render 'layouts/search_bar' %>
   </div>
-  <div class="row total-jobs">
-    <div class="col-4">Total: <%= @total_job %> jobs</div>
-    <div class="col-4">Result for: <%= @result_for_job %> jobs</div>
+  <div class="total-jobs">
+    <div class="total">Total: <strong><%= @result_for_job %></strong> jobs in <strong><%= @city.name %></strong></div>
   </div>
   <%= render "jobs/pagination" %>
   <div class="job-list">

app/views/jobs/index.html.erb

@@ -3,9 +3,8 @@
   <div class="search-bar">
     <%= render 'layouts/search_bar' %>
   </div>
-  <div class="row total-jobs">
-    <div class="col-4">Total: <%= @total_job %> jobs</div>
-    <div class="col-4">Result for: <%= @total_job %> jobs</div>
+  <div class="total-jobs">
+    <div class="total">Total: <strong><%= @total_job %></strong> jobs</div>
   </div>
   <%= render "jobs/pagination" %>
   <div class="job-list">

app/views/jobs/industry_jobs.html.erb

@@ -3,9 +3,8 @@
   <div class="search-bar">
     <%= render 'layouts/search_bar' %>
   </div>
-  <div class="row total-jobs">
-    <div class="col-4">Total: <%= @total_job %> jobs</div>
-    <div class="col-4">Result for: <%= @result_for_job %> jobs</div>
+  <div class="total-jobs">
+    <div class="total">Total: <strong><%= @result_for_job %></strong> jobs in <strong><%= @industry.name %></strong></div>
   </div>
   <%= render "jobs/pagination" %>
   <div class="job-list">

app/views/layouts/_show_cities.html.erb

 <div class="col-4">
   <div class="row-table border border-dark rounded city-list">
-    <%= link_to city_jobs_path(name: city.name) do %>
+    <%= link_to city_jobs_path(converted_name: city.converted_name) do %>
       <div class="city-name"><strong><%= city.name %></strong></div>
       <div class="count-job"><%= city.jobs.count %></div>
     <% end %>

app/views/layouts/_show_industries.html.erb

 <div class="col-4">
   <div class="row-table border border-dark rounded industry-list">
-    <%= link_to industry_jobs_path(industry.id) do %>
+    <%= link_to industry_jobs_path(converted_name: industry.converted_name) do %>
       <div class="industry-name"><strong><%= industry.name %></strong></div>
       <div class="count-job"><%= industry.jobs.count %></div>
     <% end %>

app/views/layouts/_show_jobs.html.erb

@@ -5,9 +5,7 @@
       <div><%= job.company_name %></div>
       <div class="salary">💲 Salary: <%= job.salary %></div>
       <div>▼
-        <% job.cities.each do |city| %>
-          <%= city.name %>
-        <% end %>
+        <%= job.cities.map(&:name).join(' | ') %>
       </div>
       <div class="row">
         <div class="col-10 introduction">

config/routes.rb

 Rails.application.routes.draw do
   # For details on the DSL available within this file, see http://guides.rubyonrails.org/routing.html
   resources :jobs
-  get 'jobs/city/:name', to: 'jobs#city_jobs', as: :city_jobs
-  get 'jobs/industry/:id', to: 'jobs#industry_jobs', as: :industry_jobs
+  get 'jobs/city/:converted_name', to: 'jobs#city_jobs', as: :city_jobs
+  get 'jobs/industry/:converted_name', to: 'jobs#industry_jobs', as: :industry_jobs
 
   resources :top_pages
   resources :industries

db/migrate/20200715012914_create_jobs.rb

@@ -8,6 +8,8 @@ class CreateJobs < ActiveRecord::Migration[5.2]
       t.string :experience
       t.string :expiration_date
       t.bigint :company_id
+      t.string :converted_name
+
       t.timestamps
     end
   end

db/migrate/20200715013619_create_cities.rb

@@ -3,6 +3,7 @@ class CreateCities < ActiveRecord::Migration[5.2]
     create_table :cities, :options => 'COLLATE=utf8_general_ci' do |t|
       t.string :name
       t.boolean :location
+      t.string :converted_name
 
       t.timestamps
     end

db/migrate/20200715014000_create_industries.rb

@@ -2,6 +2,7 @@ class CreateIndustries < ActiveRecord::Migration[5.2]
   def change
     create_table :industries, :options => 'COLLATE=utf8_general_ci' do |t|
       t.string :name
+      t.string :converted_name
 
       t.timestamps
     end

db/migrate/20200715014638_create_companies.rb

@@ -4,7 +4,8 @@ class CreateCompanies < ActiveRecord::Migration[5.2]
       t.string :name
       t.text :address
       t.text :introduction
-      
+      t.string :converted_name
+
       t.timestamps
     end
   end

db/schema.rb

@@ -10,11 +10,12 @@
 #
 # It's strongly recommended that you check this file into your version control system.
 
-ActiveRecord::Schema.define(version: 2020_07_23_071239) do
+ActiveRecord::Schema.define(version: 2020_07_15_035356) do
 
   create_table "cities", options: "ENGINE=InnoDB DEFAULT CHARSET=utf8", force: :cascade do |t|
     t.string "name"
     t.boolean "location"
+    t.string "converted_name"
     t.datetime "created_at", null: false
     t.datetime "updated_at", null: false
   end
@@ -30,6 +31,7 @@ ActiveRecord::Schema.define(version: 2020_07_23_071239) do
     t.string "name"
     t.text "address"
     t.text "introduction"
+    t.string "converted_name"
     t.datetime "created_at", null: false
     t.datetime "updated_at", null: false
   end
@@ -50,6 +52,7 @@ ActiveRecord::Schema.define(version: 2020_07_23_071239) do
 
   create_table "industries", options: "ENGINE=InnoDB DEFAULT CHARSET=utf8", force: :cascade do |t|
     t.string "name"
+    t.string "converted_name"
     t.datetime "created_at", null: false
     t.datetime "updated_at", null: false
   end
@@ -79,6 +82,7 @@ ActiveRecord::Schema.define(version: 2020_07_23_071239) do
     t.string "experience"
     t.string "expiration_date"
     t.bigint "company_id"
+    t.string "converted_name"
     t.datetime "created_at", null: false
     t.datetime "updated_at", null: false
   end

lib/src/crawler.rb

 
 class Crawler
-  
+
   def initialize(logger, url)
     @logger = logger
     @url = url
@@ -17,14 +17,16 @@ class Crawler
     page = Nokogiri::HTML(URI.open(@url))
     get_name = page.search('select#location')
     data_city = get_name.search('option').map(&:text).map(&:strip)
-    
+
     data_city.each do |name_city|
       if City.find_by(id: 70)
-        city = City.create!(name: name_city,
-                            location: 0)
+        city = City.find_or_create_by!(name: name_city) do |city|
+          city.location = 0
+        end
       else
-        city = City.create!(name: name_city,
-                            location: 1)
+        city = City.find_or_create_by!(name: name_city) do |city|
+          city.location = 1
+        end
       end
     end
   end
@@ -43,15 +45,21 @@ class Crawler
   def city_relationship(row, job)
     location_relationship = row.css('div.map p a').children.map { |name_city| name_city.text.strip }
     cities_relationship = City.where(name: location_relationship)
+    city_job_relationship = CityJob.where(job_id: job.id ,city_id: cities_relationship.ids)
 
-    job.cities << cities_relationship
+    if city_job_relationship.blank?
+      job.cities << cities_relationship
+    end
   end
 
   def industry_relationship(row, job)
     industry_relationship = row.css('li a').children.map { |name_industry| name_industry.text.strip }
     industries_relationship = Industry.where(name: industry_relationship)
+    industry_job_relationship = IndustryJob.where(job_id: job.id, industry_id: industries_relationship.ids)
 
-    job.industries << industries_relationship
+    if industry_job_relationship.blank?
+      job.industries << industries_relationship
+    end
   end
 
   def create_job(title, link_page, row, company)
@@ -68,7 +76,6 @@ class Crawler
                                  expiration_date: expiration_date,
                                  description: description,
                                  company_id: company.id)
-
     city_relationship(row, job)
     industry_relationship(row, job)
   end
@@ -78,14 +85,14 @@ class Crawler
       info = Nokogiri::HTML(URI.open("https://careerbuilder.vn/viec-lam/tat-ca-viec-lam-trang-#{n}-vi.html"))
       links = info.css('div.caption a.company-name').map { |link| link['href'] }
       links.each do |link|
-        next if link == 'javascript:void(0);'
-          page = Nokogiri::HTML(URI.open(URI.escape(link)))
-          name = page.search('p.name')&.text
-        next if name.blank?
-
-        address = page.css('div.content p').children[1]&.text
-        introduction = page.css('div.main-about-us').text
         begin
+          next if link == 'javascript:void(0);'
+            page = Nokogiri::HTML(URI.open(URI.escape(link)))
+            name = page.search('p.name')&.text&.strip
+          next if name.blank?
+
+          address = page.css('div.content p').children[1]&.text
+          introduction = page.css('div.main-about-us').text
           Company.find_or_create_by!(name: name,
                                      address: address,
                                      introduction: introduction)

lib/src/csv_importer.rb

@@ -54,19 +54,26 @@ class CSVImporter
         level = row["level"]
         salary = row["salary"]
 
+        job = Job.find_or_create_by!(title: title_job,
+                               description: description_job,
+                               level: level,
+                               salary: salary,
+                               company_id: company.id)
+
         industry_name = row["category"]
         industries_relationship = Industry.where(name: industry_name)
+        industry_job_relationship = IndustryJob.where(job_id: job.id, industry_id: industries_relationship.ids)
+
+        if industry_job_relationship.blank?
+          job.industries << industries_relationship
+        end
 
         location_data = row["work place"]
         location = location_data.gsub('["', '').gsub('"]', '')
         location_relationship = City.where(name: location)
+        location_job_relationship = CityJob.where(job_id: job.id ,city_id: location_relationship.ids)
 
-        Job.find_or_create_by!(title: title_job,
-                               description: description_job,
-                               level: level,
-                               salary: salary,
-                               company_id: company.id) do |job|
-          job.industries << industries_relationship
+        if location_job_relationship.blank?
           job.cities << location_relationship
         end
 

lib/src/job_parser.rb

@@ -34,15 +34,19 @@ class JobParser
   def city_relationship(row, job)
     location_relationship = row.css('div.map p a').children.map { |name_city| name_city.text.strip }
     cities_relationship = City.where(name: location_relationship)
-
-    job.cities << cities_relationship
+    city_job_relationship = CityJob.where(job_id: job.id ,city_id: cities_relationship.ids)
+    if city_job_relationship.blank?
+      job.cities << cities_relationship
+    end
   end
 
   def industry_relationship(row, job)
     industry_relationship = row.css('li a').children.map { |name_industry| name_industry.text.strip }
     industries_relationship = Industry.where(name: industry_relationship)
-
-    job.industries << industries_relationship
+    industry_job_relationship = IndustryJob.where(job_id: job.id, industry_id: industries_relationship.ids)
+    if industry_job_relationship.blank?
+      job.industries << industries_relationship
+    end
   end
 
   def create_job(title, link_page, row, company)