fix mentor's comments

app/controllers/favorite_jobs_controller.rb

@@ -2,32 +2,30 @@ class FavoriteJobsController < ApplicationController
   before_action :sign_in_validation, only: %i[create destroy index]
 
   def index
-    if params[:page].present? || params[:page] == ""
-      return redirect_to favorite_jobs_path, flash: {warning: Settings.user.favorite_job.validate_page } if params[:page].to_i <= 0 || params[:page].scan(/\D+/).present?
-    end
+    page = Integer(params[:page] || "1") rescue 0
+
+    return redirect_to favorite_jobs_path unless page.positive?
+
     @count = current_user.favorite_jobs.count
-    @favorited_jobs = current_user.favorite_jobs.order_favorite.page(params[:page]).per(Job::LIMIT_PAGE)
+    @favorited_jobs = current_user.favorite_jobs.order_favorite.page(page).per(Job::LIMIT_PAGE)
   end
 
   def create
     return if current_user.favorite_jobs.exists?(job_id: params[:job_id])
-    @follow = current_user.favorite!(params[:job_id])
+    @favorite = current_user.favorite!(params[:job_id])
     respond_to { |format| format.js }
   end
 
   def destroy
-    @unfollow = current_user.unfavorite!(params[:job_id])
+    @unfavorite = current_user.unfavorite!(params[:job_id])
 
     if request.referer.include?("favorite")
       @count = current_user.favorite_jobs.count
+      current_page_count = @count % Job::LIMIT_PAGE
+      remain_page = @count / Job::LIMIT_PAGE
 
-      count_on_page = @count % Job::LIMIT_PAGE
-      page_number = @count / Job::LIMIT_PAGE
-      link_url = request.referer.to_s.split("=")
-
-      return redirect_to link_url[0] + "=" + page_number.to_s if count_on_page == Job::DIVISIBLE && link_url[1].to_i == page_number + 1
-
-      return redirect_to request.referer if count_on_page == Job::DIVISIBLE
+      return redirect_to favorite_jobs_path(page: remain_page) if current_page_count == Job::DIVISIBLE && params[:page] == remain_page + 1
+      return redirect_to favorite_jobs_path(page: remain_page) if current_page_count == Job::DIVISIBLE
     end
 
     respond_to { |format| format.js }

app/views/favorite_jobs/_favorite_job.html.erb

@@ -21,7 +21,7 @@
           <div class="salary col-3">
             Salary: <%= favorite_job.job.salary %>
           </div>
-          <%= link_to "Remove", unfavorite_job_path(job_id: favorite_job.job.id), method: :delete, remote: true, class: "btn btn-danger", id: "button-remove" %>
+          <%= link_to "Remove", unfavorite_job_path(job_id: favorite_job.job.id, page: params[:page]), method: :delete, remote: true, class: "btn btn-danger", id: "button-remove" %>
         </div>
       </div>
     </div>

app/views/favorite_jobs/create.js.erb

-$("#favorite-form-<%= @follow.job_id %>").html("<%=escape_javascript render 'users/unfavorite', job_id: @follow.job_id %>");
+$("#favorite-form-<%= @favorite.job_id %>").html("<%=escape_javascript render 'users/unfavorite', job_id: @favorite.job_id %>");

app/views/favorite_jobs/destroy.js.erb

-$("#favorite-form-<%= @unfollow.job_id %>").html("<%= j render 'users/favorite', job_id: @unfollow.job_id %>");
-$(".job-id-<%= @unfollow.job_id %>").remove();
+$("#favorite-form-<%= @unfavorite.job_id %>").html("<%= j render 'users/favorite', job_id: @unfavorite.job_id %>");
+$(".job-id-<%= @unfavorite.job_id %>").remove();
 $(".count-favorite-jobs").html("<%= @count %>");