change find id to slug

app/assets/stylesheets/custom.scss

@@ -58,7 +58,7 @@
   }
 }
 
-.apply-job btn{
+.apply-job .btn {
   align-items: center;
   justify-content: center;
 }

app/controllers/jobs_controller.rb

@@ -14,6 +14,6 @@ class JobsController < ApplicationController
   end
 
   def show
-    @job = Job.latest_jobs.find_by(id: params[:job_id])
+    @job = Job.latest_jobs.find_by(slug: params[:job_slug])
   end
 end
\ No newline at end of file

app/helpers/application_helper.rb

 module ApplicationHelper
+  def format_datetime(input)
+    input.strftime('%d/%m/%Y')
+  end 
 end

app/models/job.rb

 class Job < ApplicationRecord
+  extend FriendlyId
+  friendly_id :title, use: %i[slugged finders]
   belongs_to :company
   has_many :apply_jobs, dependent: :destroy
   has_many :favorite_jobs, dependent: :destroy
@@ -7,4 +9,8 @@ class Job < ApplicationRecord
   has_and_belongs_to_many :cities
   LATEST_JOB_NUMBER = 5
   scope :latest_jobs, -> { includes(:cities, :industries, :company).order('created_at DESC') }
+
+  def normalize_friendly_id(string)
+    string.to_s.to_slug.normalize(transliterations: :vietnamese).to_s
+  end
 end
\ No newline at end of file

app/views/jobs/index.html.slim

@@ -15,9 +15,9 @@
       .row.bg-white
         .col-10.p-3.border.card-body.text-dark
           h5.mb-1
-            = link_to job.title, detail_path(job.id)
+            = link_to job.title, detail_path(job.slug)
           p.mb-1
-            = link_to job.company.name, "#"
+            = job.company.name
           p.mb-1
             i.fas.fa-dollar-sign.m-1
             | Lương: 

app/views/jobs/show.html.slim

@@ -6,7 +6,7 @@
     h1.mb-2
       = @job.title
     h3.mb-2
-      = link_to @job.company.name, "#"
+      = @job.company.name
     .row
       .col
         p.mb-2
@@ -28,7 +28,7 @@
           = @job.experience
         p.mb-2
           | Expired at: 
-          = @job.expired_at.strftime("%d/%m/%Y")
+          = format_datetime(@job.expired_at)
     h5.my-3
       | Benefits
     p.mb-2

app/views/top/index.html.slim

@@ -11,9 +11,9 @@ h3.p-2
         .card.my-3
           .card-body.text-dark
             h5.mb-1
-              = link_to job.title, detail_path(job.id)
+              = link_to job.title, detail_path(job.slug)
             p.mb-1
-              = link_to job.company.name, "#"
+              = job.company.name
             p.mb-1
               i.fas.fa-dollar-sign.m-1
               | Lương: 

config/routes.rb

@@ -4,5 +4,5 @@ Rails.application.routes.draw do
   get 'industries', to: 'industries#show'
   get 'jobs/city/:city_slug', to: 'jobs#index', as: 'city_slug'
   get 'jobs/industry/:industry_slug', to: 'jobs#index', as: 'industry_slug'
-  get 'detail/:job_id', to: 'jobs#show', as: 'detail'
+  get 'detail/:job_slug', to: 'jobs#show', as: 'detail'
 end
\ No newline at end of file

db/migrate/20210805021856_add_slug_to_jobs.rb

+class AddSlugToJobs < ActiveRecord::Migration[6.1]
+  def change
+    add_column :jobs, :slug, :string
+    add_index :jobs, :slug, unique: true
+  end
+end

db/schema.rb

@@ -10,7 +10,7 @@
 #
 # It's strongly recommended that you check this file into your version control system.
 
-ActiveRecord::Schema.define(version: 2021_07_31_111344) do
+ActiveRecord::Schema.define(version: 2021_08_05_021856) do
 
   create_table "apply_jobs", charset: "utf8mb4", collation: "utf8mb4_0900_ai_ci", force: :cascade do |t|
     t.bigint "user_id", null: false
@@ -119,7 +119,9 @@ ActiveRecord::Schema.define(version: 2021_07_31_111344) do
     t.datetime "expired_at"
     t.datetime "created_at", precision: 6, null: false
     t.datetime "updated_at", precision: 6, null: false
+    t.string "slug"
     t.index ["company_id"], name: "index_jobs_on_company_id"
+    t.index ["slug"], name: "index_jobs_on_slug", unique: true
   end
 
   create_table "regions", charset: "utf8mb4", collation: "utf8mb4_0900_ai_ci", force: :cascade do |t|