fix bugs

app/assets/javascripts/application.js

@@ -11,10 +11,9 @@
 // about supported directives.
 //
 //= require rails-ujs
-//= require_tree .
-//= require jquery-3.2.1.min.js
-//= require bootstrap.min.js
-//= require bootstrap-datetimepicker.min.js
+//= require jquery-3.2.1.min
+//= require bootstrap.min
+//= require bootstrap-datetimepicker.min
 
 $(document).ready(function(){
   // this function to hide message after 5s

app/controllers/admins/applies_controller.rb

 require 'rsolr'
 require "csv"
+require 'uri'
 
 class Admins::AppliesController < ApplicationController
   def index
-    @cities = City.pluck(:id, :name)
     if params[:commit]
       # get condition here
       condition = get_condition
@@ -13,18 +13,16 @@ class Admins::AppliesController < ApplicationController
 
       @applications = ApplyJob.where(job_id: job_id).includes(:job, :user)
       if params[:commit].eql? 'Down csv'
-        flash[:notice] = 'Down csv'
         down_csv(@applications)
+        return
       end
     else
       # get applications
       @applications = ApplyJob.includes(:job, :user)
     end
-    puts params[:commit]
   end
 
   def down_csv(applications)
-
     # handle data
     data_csv = []
     applications.each do |application|
@@ -36,19 +34,8 @@ class Admins::AppliesController < ApplicationController
       candidate[:applied_at] = application.created_at
       data_csv << candidate
     end
-
-    # create new csv file
-    CSV.open("file.csv", "wb") do |csv|
-      # write header
-      csv << data_csv.first.keys
-      # write values
-      data_csv.each_with_index do |data, i|
-        csv << data.values
-      end
-    end
-
-    # down file.csv into local
-    send_file "#{Rails.root}/file.csv", type: 'application/csv'
+    column_names = data_csv.first.keys
+    send_data ApplyJob.to_csv(column_names, data_csv), filename: "applications-#{Date.today}.csv"
   end
 
   private
@@ -61,7 +48,7 @@ class Admins::AppliesController < ApplicationController
     # Direct connection
     connect
     # use get method to query
-    response = @solr.get 'select', :params => condition
+    response = @solr.get 'select', params: condition
     response
   end
 

app/controllers/application_controller.rb

 class ApplicationController < ActionController::Base
   protect_from_forgery with: :exception
-  helper_method :clear_session_candidate, :admin_can_not_do_this
 
   def clear_session_candidate
     session[:candidate] = {}

app/models/apply_job.rb

@@ -4,4 +4,13 @@ class ApplyJob < ApplicationRecord
   validates :cv, presence: true
   validates :email, presence: true
   validates :name, presence: true
+
+  def self.to_csv(column_names, applications)
+    CSV.generate do |csv|
+      csv << column_names
+      applications.each do |application|
+        csv << application.values
+      end
+    end
+  end
 end

app/views/admins/applies/_application.html.erb

-<% @applications.each do |application| %>
+<% applications.each do |application| %>
   <div class="job-intro well mr0 mrBot20">
     <h4 class="mr0"><%= link_to application.job.name, job_path(application.job) %></h4>
     <p><%= "Candidate Name: #{application.user.name}" %></p>