Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
V
VeNJob
  • Overview
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 1
    • Merge Requests 1
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Tô Ngọc Ánh
  • VeNJob
  • Merge Requests
  • !4

Merged
Opened Jul 23, 2020 by Tô Ngọc Ánh@anhtn 
  • Report abuse
Report abuse

refactor code

×

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch origin
git checkout -b crawler origin/crawler

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git checkout master
git merge --no-ff crawler

Step 4. Push the result of the merge to GitLab

git push origin master

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

  • Discussion 1
  • Commits 3
  • Pipelines 3
  • Changes 4
{{ resolvedDiscussionCount }}/{{ discussionCount }} {{ resolvedCountText }} resolved
  • Thanh Hung Pham
    @hungpt started a discussion on an old version of the diff Jul 23, 2020
    Resolved by Tô Ngọc Ánh Jul 23, 2020
    lib/tasks/crawler.rake
    1 1 require "open-uri"
    2 2
    3 3 namespace :crawl do
    4 desc "crawl industries and locations"
    5 task crawl_industries_locations: :environment do
    4 desc "crawl industries locations jobs"
    5 task :crawl_industries_locations_jobs, [:page, :link] => [:environment] do |task, args|
    6 args.with_defaults(link: 'https://careerbuilder.vn/viec-lam/tat-ca-viec-lam-vi.html')
    6 7 crawl_industries_and_locations
    8 job_links = get_job_links(args[:page].to_i, args[:link])
    9 job_links.each do |link|
    10 break if link.empty?
    • Thanh Hung Pham @hungpt commented Jul 23, 2020
      Master

      @anhtn chỗ này là next chứ nhỉ ? em break là nó dừng luôn vòng lặp rồi ?

      Edited Jul 23, 2020
      @anhtn chỗ này là `next` chứ nhỉ ? em `break` là nó dừng luôn vòng lặp rồi ?
    • Tô Ngọc Ánh @anhtn

      changed this line in version 2 of the diff

      Jul 23, 2020

      changed this line in version 2 of the diff

      changed this line in [version 2 of the diff](https://gitlab.zigexn.vn/anhtn/VeNJob/merge_requests/4/diffs?diff_id=4850&start_sha=c4c8c6562e4229f872aa55dc33356e61f84fb7eb#b321b772986de9dfe9db0ed4138ae166e577f241_10_11)
      Toggle commit list
    Please register or sign in to reply
  • Tô Ngọc Ánh @anhtn

    resolved all discussions

    Jul 23, 2020

    resolved all discussions

    resolved all discussions
    Toggle commit list
  • Tô Ngọc Ánh @anhtn

    added 1 commit

    • 61ab1820 - Logger, crontab

    Compare with previous version

    Jul 23, 2020

    added 1 commit

    • 61ab1820 - Logger, crontab

    Compare with previous version

    added 1 commit * 61ab1820 - Logger, crontab [Compare with previous version](https://gitlab.zigexn.vn/anhtn/VeNJob/merge_requests/4/diffs?diff_id=4850&start_sha=c4c8c6562e4229f872aa55dc33356e61f84fb7eb)
    Toggle commit list
  • Tô Ngọc Ánh @anhtn

    added 1 commit

    • 102be3eb - Fix bug convert info detail job

    Compare with previous version

    Jul 24, 2020

    added 1 commit

    • 102be3eb - Fix bug convert info detail job

    Compare with previous version

    added 1 commit * 102be3eb - Fix bug convert info detail job [Compare with previous version](https://gitlab.zigexn.vn/anhtn/VeNJob/merge_requests/4/diffs?diff_id=4851&start_sha=61ab1820dc1b8fc0b633509f62bda40156122b2d)
    Toggle commit list
  • Tô Ngọc Ánh @anhtn

    mentioned in commit ed8bc042

    Jul 24, 2020

    mentioned in commit ed8bc042

    mentioned in commit ed8bc0426063166ac6b4ecc5daf1d64aba2f4b94
    Toggle commit list
  • Tô Ngọc Ánh @anhtn

    merged

    Jul 24, 2020

    merged

    merged
    Toggle commit list
  • Write
  • Preview
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or sign in to comment
Assignee
No assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
2
2 participants
Reference: anhtn/VeNJob!4
×

Revert this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.
×

Cherry-pick this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.