Added 1 commit:

• f6cdd883 - Restruct space

Added 1 commit:

• da5d87f3 - 2.2 User management feature, 2.3 Item posting feature

@dieutb per_page should belong to model. Can you move it to Category model?

https://github.com/amatsuda/kaminari#configuring-default-per_page-value-for-each-model

@dieutb You set default page in here. But kaminari sets to first page if params[:page] is blank. So you don't need to set params[:page] here

@dieutb in rails 4, we use before_action. Please check all controller and change to before_action

@dieutb need new line between methods. It looks easier

@dieutb rails has helpers like number_to_currency. You can use it instead of write new method http://api.rubyonrails.org/

@dieutb use space before } and after { Please take a look on convention

http://wiki.zigexn.vn/doku.php?id=coding_rule

https://github.com/bbatsov/ruby-style-guide

@dieutb Where does this method be used? If it is only used in views. Just put it in helper

@dieutb You can use decorator to wrap this method instead of putting in views There is a gem for decorator: https://github.com/drapergem/draper

Yes I have use it in controller, too

It is the syntax for currency in view. In view have many places show price. When we want change syntax, we just only edit function in helper

'In view have many places show price' --> so you can write currency_number to wrap number_to_currency

Status changed to closed