fixed review

app/models/city.rb

 class City < ApplicationRecord
 class City < ApplicationRecord
   has_and_belongs_to_many :jobs
   has_and_belongs_to_many :jobs
+  enum region: { vietnam: 0, international: 1 }
 end
 end

lib/tasks/web_crawler.rake

@@ -79,17 +79,11 @@ namespace :crawler do
                                   benefit: benefits,
                                   benefit: benefits,
                                   requirement: requirement,
                                   requirement: requirement,
                                   other_info: other_info,
                                   other_info: other_info,
-                                  company_id: company_object.id,
-                                  created_at: update_at,
-                                  updated_at: update_at })
-        industries.map do |industry|
-          industry_objects = Industry.find_or_create_by(name: industry)
-          job_object.industries << industry_objects
-        end
-        cities.map do |city|
-          city_objects = City.find_or_create_by(name: city)
-          job_object.cities << city_objects
-        end
+                                  company_id: company_object.id })
+        industry_objects = industries.map { |industry| Industry.find_or_create_by(name: industry) }
+        job_object.industries << industry_objects
+        city_objects = cities.map { |city| City.find_or_create_by(name: city) }
+        job_object.cities << city_objects
       rescue URI::InvalidURIError => e
       rescue URI::InvalidURIError => e
         puts "[Error] #{e.message}"
         puts "[Error] #{e.message}"
         encode_url = CGI.escape(url.remove('https://careerbuilder.vn/vi/tim-viec-lam/'))
         encode_url = CGI.escape(url.remove('https://careerbuilder.vn/vi/tim-viec-lam/'))
@@ -116,20 +110,16 @@ namespace :crawler do
   task cities: :environment do
   task cities: :environment do
     parsed_page ||= Nokogiri::HTML(HTTParty.get('https://careerbuilder.vn/tim-viec-lam.html').body)
     parsed_page ||= Nokogiri::HTML(HTTParty.get('https://careerbuilder.vn/tim-viec-lam.html').body)
     list_location = parsed_page.css('div.main-jobs-by-location ul li')
     list_location = parsed_page.css('div.main-jobs-by-location ul li')
-    list_location.each do |part|
-      city_name = part.text
-      region = 1
-      if city_name.include?(key = 'Việc làm tại')
-        city_name = city_name.remove(key).strip
-        region = 0
+    list_location.each do |city|
+      city_name = city.text
+      region = City.regions[:international]
+      if city_name.include?('Việc làm tại')
+        city_name = city_name.remove('Việc làm tại').strip
+        region = City.regions[:vietnam]
       end
       end
-      city = {
+      City.create(
         name: city_name,
         name: city_name,
         region: region
         region: region
-      }
-      City.create(
-        name: city[:name],
-        region: city[:region]
       )
       )
     end
     end
   end
   end