Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
V
VenJob
  • Overview
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Mai Hoang Thai Ha
  • VenJob
  • Merge Requests
  • !1

Merged
Opened Jul 01, 2021 by Mai Hoang Thai Ha@hamht 
  • Report abuse
Report abuse

add layout header and footer

From static-pages into master

  • Discussion 7
  • Commits 4
  • Pipelines 4
  • Changes 16
{{ resolvedDiscussionCount }}/{{ discussionCount }} {{ resolvedCountText }} resolved
  • phuctmZigexn
    @phuctm started a discussion on an old version of the diff Jul 06, 2021
    Last updated by Mai Hoang Thai Ha Jul 06, 2021
    app/controllers/static_pages_controller.rb 0 → 100644
    1 class StaticPagesController < ApplicationController
    2 def home
    • phuctmZigexn @phuctm commented Jul 06, 2021
      Master

      home, help không phải là action nằm trong restful nha.

      `home`, `help` không phải là action nằm trong restful nha.
    • Mai Hoang Thai Ha @hamht

      changed this line in version 2 of the diff

      Jul 06, 2021

      changed this line in version 2 of the diff

      changed this line in [version 2 of the diff](https://gitlab.zigexn.vn/hamht/VenJob/merge_requests/1/diffs?diff_id=5299&start_sha=7bf75241e86cf05aac871ab3e559fe2966340eb1#e411ad7eefd53bf4aa08f4a552ee9cbdb8f5a0f2_2_0)
      Toggle commit list
    Please register or sign in to reply
  • phuctmZigexn
    @phuctm started a discussion on an old version of the diff Jul 06, 2021
    Last updated by Mai Hoang Thai Ha Jul 06, 2021
    app/helpers/static_pages_helper.rb 0 → 100644
    1 module StaticPagesHelper
    • phuctmZigexn @phuctm commented Jul 06, 2021
      Master

      file nào không có nội dung thì xóa đi nha em. Khi nào cần thì tạo lại. Tránh việc quá nhiều file khi review

      file nào không có nội dung thì xóa đi nha em. Khi nào cần thì tạo lại. Tránh việc quá nhiều file khi review
    • Mai Hoang Thai Ha @hamht

      changed this line in version 2 of the diff

      Jul 06, 2021

      changed this line in version 2 of the diff

      changed this line in [version 2 of the diff](https://gitlab.zigexn.vn/hamht/VenJob/merge_requests/1/diffs?diff_id=5299&start_sha=7bf75241e86cf05aac871ab3e559fe2966340eb1#611a3b132a6645ce3eb70c73c7b9fcf7d292b6e5_1_0)
      Toggle commit list
    Please register or sign in to reply
  • phuctmZigexn
    @phuctm started a discussion on an old version of the diff Jul 06, 2021
    Last updated by Mai Hoang Thai Ha Jul 06, 2021
    app/views/layouts/_footer.html.erb 0 → 100644
    1 <footer class="footer">
    • phuctmZigexn @phuctm commented Jul 06, 2021
      Master

      Từ bây giờ, đối với view template thì mình sẽ sử dụng slim template. Tìm hiểu và áp dụng vào tất cả các view nha em

      https://github.com/slim-template/slim

      Edited Jul 06, 2021 by phuctmZigexn
      Từ bây giờ, đối với view template thì mình sẽ sử dụng slim template. Tìm hiểu và áp dụng vào tất cả các view nha em https://github.com/slim-template/slim
    • Mai Hoang Thai Ha @hamht

      changed this line in version 2 of the diff

      Jul 06, 2021

      changed this line in version 2 of the diff

      changed this line in [version 2 of the diff](https://gitlab.zigexn.vn/hamht/VenJob/merge_requests/1/diffs?diff_id=5299&start_sha=7bf75241e86cf05aac871ab3e559fe2966340eb1#54cecaa0789321374b83fdb8ec960ff4d886f1cb_1_0)
      Toggle commit list
    Please register or sign in to reply
  • phuctmZigexn
    @phuctm started a discussion on an old version of the diff Jul 06, 2021
    Last updated by Mai Hoang Thai Ha Jul 06, 2021
    config/routes.rb
    1 1 Rails.application.routes.draw do
    2 root 'application#hello'
    2 root 'static_pages#home'
    3 get 'help' => 'static_pages#help'
    • phuctmZigexn @phuctm commented Jul 06, 2021
      Master

      sử dụng cú pháp mới nhé. => get 'help', to: 'static_pages#help'

      Tham khảo: https://guides.rubyonrails.org/routing.html

      sử dụng cú pháp mới nhé. => `get 'help', to: 'static_pages#help'` Tham khảo: https://guides.rubyonrails.org/routing.html
    • Mai Hoang Thai Ha @hamht

      changed this line in version 2 of the diff

      Jul 06, 2021

      changed this line in version 2 of the diff

      changed this line in [version 2 of the diff](https://gitlab.zigexn.vn/hamht/VenJob/merge_requests/1/diffs?diff_id=5299&start_sha=7bf75241e86cf05aac871ab3e559fe2966340eb1#e801163eb9182955dca3eb9817d59af634f6665d_3_2)
      Toggle commit list
    Please register or sign in to reply
  • phuctmZigexn
    @phuctm started a discussion on an old version of the diff Jul 06, 2021
    Last updated by Mai Hoang Thai Ha Jul 06, 2021
    config/routes.rb
    1 1 Rails.application.routes.draw do
    2 root 'application#hello'
    2 root 'static_pages#home'
    3 get 'help' => 'static_pages#help'
    4 get 'about' => 'static_pages#about'
    5 # get 'contact' => 'static_pages#contact'
    • phuctmZigexn @phuctm commented Jul 06, 2021
      Master

      code bị comment thì xóa luôn nha. Trừ những nội dung text nhầm mô tả, chú thích cho nội dung code.

      code bị comment thì xóa luôn nha. Trừ những nội dung text nhầm mô tả, chú thích cho nội dung code.
    • Mai Hoang Thai Ha @hamht

      changed this line in version 2 of the diff

      Jul 06, 2021

      changed this line in version 2 of the diff

      changed this line in [version 2 of the diff](https://gitlab.zigexn.vn/hamht/VenJob/merge_requests/1/diffs?diff_id=5299&start_sha=7bf75241e86cf05aac871ab3e559fe2966340eb1#e801163eb9182955dca3eb9817d59af634f6665d_5_2)
      Toggle commit list
    Please register or sign in to reply
  • phuctmZigexn
    @phuctm started a discussion on an old version of the diff Jul 06, 2021
    Last updated by Mai Hoang Thai Ha Jul 06, 2021
    test/controllers/static_pages_controller_test.rb 0 → 100644
    1 require "test_helper"
    • phuctmZigexn @phuctm commented Jul 06, 2021
      Master

      hiện tại mình không cần viết test cho app. nên em xóa mấy file test được generate ra khi chạy command generate controller, model này nọ nha. Ngoài ra thì có 2 cách khác:

      1. thêm --no-test-framework vào command rails generate...
      2. áp dụng thử link này https://stackoverflow.com/questions/18001306/dont-generate-test-automatically-in-rails
      hiện tại mình không cần viết test cho app. nên em xóa mấy file test được generate ra khi chạy command generate controller, model này nọ nha. Ngoài ra thì có 2 cách khác: 1. thêm `--no-test-framework` vào command `rails generate...` 2. áp dụng thử link này https://stackoverflow.com/questions/18001306/dont-generate-test-automatically-in-rails
    • Mai Hoang Thai Ha @hamht

      changed this line in version 2 of the diff

      Jul 06, 2021

      changed this line in version 2 of the diff

      changed this line in [version 2 of the diff](https://gitlab.zigexn.vn/hamht/VenJob/merge_requests/1/diffs?diff_id=5299&start_sha=7bf75241e86cf05aac871ab3e559fe2966340eb1#1d9ba264cd09ea2b73fa1a5980c69839a1613d55_1_0)
      Toggle commit list
    Please register or sign in to reply
  • phuctmZigexn
    @phuctm started a discussion on an old version of the diff Jul 06, 2021
    Last updated by Mai Hoang Thai Ha Jul 06, 2021
    app/views/static_pages/help.html.erb 0 → 100644
    1 <h1>StaticPages#help</h1>
    • phuctmZigexn @phuctm commented Jul 06, 2021
      Master

      những view này nếu requirement không yêu cầu thì em xóa luôn nha.

      những view này nếu requirement không yêu cầu thì em xóa luôn nha.
    • Mai Hoang Thai Ha @hamht

      changed this line in version 2 of the diff

      Jul 06, 2021

      changed this line in version 2 of the diff

      changed this line in [version 2 of the diff](https://gitlab.zigexn.vn/hamht/VenJob/merge_requests/1/diffs?diff_id=5299&start_sha=7bf75241e86cf05aac871ab3e559fe2966340eb1#f3c9ba42a8274d74479945a7a3b975d9b1120caa_1_0)
      Toggle commit list
    Please register or sign in to reply
  • Mai Hoang Thai Ha @hamht

    added 1 commit

    • 9533f83a - rename branch, add top_controller, add slim, add gem pry-rails and pry-nav, remove test framework

    Compare with previous version

    Jul 06, 2021

    added 1 commit

    • 9533f83a - rename branch, add top_controller, add slim, add gem pry-rails and pry-nav, remove test framework

    Compare with previous version

    added 1 commit * 9533f83a - rename branch, add top_controller, add slim, add gem pry-rails and pry-nav, remove test framework [Compare with previous version](https://gitlab.zigexn.vn/hamht/VenJob/merge_requests/1/diffs?diff_id=5299&start_sha=7bf75241e86cf05aac871ab3e559fe2966340eb1)
    Toggle commit list
  • Mai Hoang Thai Ha @hamht

    added 1 commit

    • 11eadd19 - add slim-rails gem

    Compare with previous version

    Jul 06, 2021

    added 1 commit

    • 11eadd19 - add slim-rails gem

    Compare with previous version

    added 1 commit * 11eadd19 - add slim-rails gem [Compare with previous version](https://gitlab.zigexn.vn/hamht/VenJob/merge_requests/1/diffs?diff_id=5300&start_sha=9533f83adfff98d617bde19dabfe96d0986ca894)
    Toggle commit list
  • Mai Hoang Thai Ha @hamht

    added 1 commit

    • 4de379b0 - remove stylesheets

    Compare with previous version

    Jul 06, 2021

    added 1 commit

    • 4de379b0 - remove stylesheets

    Compare with previous version

    added 1 commit * 4de379b0 - remove stylesheets [Compare with previous version](https://gitlab.zigexn.vn/hamht/VenJob/merge_requests/1/diffs?diff_id=5301&start_sha=11eadd1927f1c208f26c39a7d599c85a69ef6a1d)
    Toggle commit list
  • phuctmZigexn @phuctm

    mentioned in commit c4f21c57

    Jul 06, 2021

    mentioned in commit c4f21c57

    mentioned in commit c4f21c57d2f2655e9e7b8ac639969e530ab99687
    Toggle commit list
  • phuctmZigexn @phuctm

    merged

    Jul 06, 2021

    merged

    merged
    Toggle commit list
  • Write
  • Preview
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or sign in to comment
Assignee
No assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
2
2 participants
Reference: hamht/VenJob!1
×

Revert this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.
×

Cherry-pick this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.