Commit 37623935 by Mai Hoang Thai Ha

Implement advanced login

parent 33064d7a
Pipeline #1264 failed with stages
in 0 seconds
...@@ -180,6 +180,20 @@ input { ...@@ -180,6 +180,20 @@ input {
} }
} }
.checkbox {
margin-top: -10px;
margin-bottom: 10px;
span {
margin-left: 20px;
font-weight: normal;
}
}
#session_remember_me {
width: auto;
margin-left: 0;
}
@media (max-width: 800px) { @media (max-width: 800px) {
footer { footer {
small { small {
......
...@@ -6,6 +6,7 @@ class SessionsController < ApplicationController ...@@ -6,6 +6,7 @@ class SessionsController < ApplicationController
user = User.find_by(email: params[:session][:email].downcase) user = User.find_by(email: params[:session][:email].downcase)
if user && user.authenticate(params[:session][:password]) if user && user.authenticate(params[:session][:password])
log_in user log_in user
params[:session][:remember_me] == '1'? remember(user) : forget(user)
redirect_to user redirect_to user
else else
flash.now[:danger] = 'Invalid email/password combination' flash.now[:danger] = 'Invalid email/password combination'
...@@ -14,7 +15,7 @@ class SessionsController < ApplicationController ...@@ -14,7 +15,7 @@ class SessionsController < ApplicationController
end end
def destroy def destroy
log_out log_out if logged_in?
redirect_to root_url redirect_to root_url
end end
end end
...@@ -12,6 +12,7 @@ class UsersController < ApplicationController ...@@ -12,6 +12,7 @@ class UsersController < ApplicationController
@user = User.new(user_params) @user = User.new(user_params)
if @user.save if @user.save
log_in @user log_in @user
remember @user
flash[:success] = "Welcome to the Sample App!" flash[:success] = "Welcome to the Sample App!"
redirect_to @user redirect_to @user
else else
......
...@@ -5,10 +5,23 @@ module SessionsHelper ...@@ -5,10 +5,23 @@ module SessionsHelper
session[:user_id] = user.id session[:user_id] = user.id
end end
def remember(user)
user.remember
cookies.permanent.encrypted[:user_id] = user.id
cookies.permanent[:remember_token] = user.remember_token
end
# Return the curent lofed-in user (if any) # Return the curent lofed-in user (if any)
def current_user def current_user
if session[:user_id] if (user_id = session[:user_id])
@current_user ||= User.find_by(id: session[:user_id]) @current_user ||= User.find_by(id: user_id)
elsif (user_id = cookies.encrypted[:user_id])
raise # The tests still pass, so this branch is currently untested.
user = User.find_by(id: user_id)
if user && user.authenticated?(cookies[:remember_token])
log_in user
@current_user = user
end
end end
end end
...@@ -17,8 +30,15 @@ module SessionsHelper ...@@ -17,8 +30,15 @@ module SessionsHelper
!current_user.nil? !current_user.nil?
end end
def forget(user)
user.forget
cookies.delete(:user_id)
cookies.delete(:remember_token)
end
def log_out def log_out
forget(current_user)
session.delete(:user_id) session.delete(:user_id)
@current_user = nil @current_user = nil
end end
end end
class User < ApplicationRecord class User < ApplicationRecord
attr_accessor :remember_token
before_save { self.email = email.downcase } before_save { self.email = email.downcase }
validates :name, presence: true, length: { maximum:50 } validates :name, presence: true, length: { maximum:50 }
VALID_EMAIL_REGEX = /\A[\w+\-.]+@[a-z\d\-.]+\.[a-z]+\z/i VALID_EMAIL_REGEX = /\A[\w+\-.]+@[a-z\d\-.]+\.[a-z]+\z/i
...@@ -14,4 +15,26 @@ class User < ApplicationRecord ...@@ -14,4 +15,26 @@ class User < ApplicationRecord
BCrypt::Engine.cost BCrypt::Engine.cost
BCrypt::Password.create(string, cost: cost) BCrypt::Password.create(string, cost: cost)
end end
# Return a random token
def User.new_token
SecureRandom.urlsafe_base64
end
# Remember a user in the database for use in persistent sessions
def remember
self.remember_token = User.new_token
update_attribute(:remember_digest, User.digest(remember_token))
end
# Return true if the given token matches the digest
def authenticated?(remember_token)
return false if remember_digest.nil?
BCrypt::Password.new(remember_digest).is_password?(remember_token)
end
# Forgets a user
def forget
update_attribute(:remember_digest, nil)
end
end end
\ No newline at end of file
...@@ -10,6 +10,11 @@ ...@@ -10,6 +10,11 @@
<%= f.label :password %> <%= f.label :password %>
<%= f.password_field :password, class: 'form-control' %> <%= f.password_field :password, class: 'form-control' %>
<%= f.label :remember_me, class: "checkbox inline" do %>
<%= f.check_box :remember_me %>
<span>Remember me on this computer</span>
<% end %>
<%= f.submit "Log in", class: "btn btn-primary" %> <%= f.submit "Log in", class: "btn btn-primary" %>
<% end %> <% end %>
......
class AddRememberDigestToUsers < ActiveRecord::Migration[6.1]
def change
add_column :users, :remember_digest, :string
end
end
...@@ -10,7 +10,7 @@ ...@@ -10,7 +10,7 @@
# #
# It's strongly recommended that you check this file into your version control system. # It's strongly recommended that you check this file into your version control system.
ActiveRecord::Schema.define(version: 2021_06_07_081815) do ActiveRecord::Schema.define(version: 2021_06_11_030107) do
create_table "users", force: :cascade do |t| create_table "users", force: :cascade do |t|
t.string "name" t.string "name"
...@@ -18,6 +18,7 @@ ActiveRecord::Schema.define(version: 2021_06_07_081815) do ...@@ -18,6 +18,7 @@ ActiveRecord::Schema.define(version: 2021_06_07_081815) do
t.datetime "created_at", precision: 6, null: false t.datetime "created_at", precision: 6, null: false
t.datetime "updated_at", precision: 6, null: false t.datetime "updated_at", precision: 6, null: false
t.string "password_digest" t.string "password_digest"
t.string "remember_digest"
t.index ["email"], name: "index_users_on_email", unique: true t.index ["email"], name: "index_users_on_email", unique: true
end end
......
...@@ -32,9 +32,21 @@ class UsersLoginTest < ActionDispatch::IntegrationTest ...@@ -32,9 +32,21 @@ class UsersLoginTest < ActionDispatch::IntegrationTest
delete logout_path delete logout_path
assert_not is_logged_in? assert_not is_logged_in?
assert_redirected_to root_url assert_redirected_to root_url
delete logout_path
follow_redirect! follow_redirect!
assert_select "a[href=?]", login_path assert_select "a[href=?]", login_path
assert_select "a[href=?]", logout_path, count: 0 assert_select "a[href=?]", logout_path, count: 0
assert_select "a[href=?]", user_path(@user), count: 0 assert_select "a[href=?]", user_path(@user), count: 0
end end
test "login with remembering" do
log_in_as(@user, remember_me: '1')
assert_not_empty cookies[:remember_token]
end
test "login without remembering" do
log_in_as(@user, remember_me: '1')
log_in_as(@user, remember_me: '0')
assert_empty cookies[:remember_token]
end
end end
...@@ -54,4 +54,8 @@ class UserTest < ActiveSupport::TestCase ...@@ -54,4 +54,8 @@ class UserTest < ActiveSupport::TestCase
@user.password = @user.password_confirmation = "a" * 5 @user.password = @user.password_confirmation = "a" * 5
assert_not @user.valid? assert_not @user.valid?
end end
test "authenticated? should return false for a user with nil digest" do
assert_not @user.authenticated?('')
end
end end
...@@ -15,4 +15,17 @@ class ActiveSupport::TestCase ...@@ -15,4 +15,17 @@ class ActiveSupport::TestCase
def is_logged_in? def is_logged_in?
!session[:user_id].nil? !session[:user_id].nil?
end end
def Log_in_as(user)
session[:user_id] = user.id
end
end end
class ActionDispatch::IntegrationTest
def log_in_as(user, password: 'password', remember_me: '1')
post login_path, params: { session: { email: user.email,
password: password,
remember_me: remember_me } }
end
end
\ No newline at end of file
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment