Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
S
sample_app
  • Overview
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Đường Sỹ Hoàng
  • sample_app
  • Merge Requests
  • !12

Merged
Opened Nov 21, 2019 by Đường Sỹ Hoàng@hoangds 
  • Report abuse
Report abuse

Following users

×

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch origin
git checkout -b following-users origin/following-users

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git checkout master
git merge --no-ff following-users

Step 4. Push the result of the merge to GitLab

git push origin master

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

  • Discussion 7
  • Commits 10
  • Changes 25
{{ resolvedDiscussionCount }}/{{ discussionCount }} {{ resolvedCountText }} resolved
  • Son Do Hong
    @sondh started a discussion on an old version of the diff Nov 21, 2019
    Last updated by Đường Sỹ Hoàng Nov 21, 2019
    app/controllers/application_controller.rb
    1 1 class ApplicationController < ActionController::Base
    2 2 protect_from_forgery with: :exception
    3 3 include SessionsHelper
    4
    5 private
    6
    7 # Confirms a logged-in user.
    8 def logged_in_user
    • Son Do Hong @sondh commented Nov 21, 2019
      Master

      indent, chú ý lỗi này, a comment nhiều lần r

      indent, chú ý lỗi này, a comment nhiều lần r
    • Đường Sỹ Hoàng @hoangds

      changed this line in version 2 of the diff

      Nov 21, 2019

      changed this line in version 2 of the diff

      changed this line in [version 2 of the diff](https://gitlab.zigexn.vn/hoangds/sample_app/merge_requests/12/diffs?diff_id=4377&start_sha=4348edead3ca4b1e58dd21ecb2515f0148a638d8#7dc0dd94f601e507e2a20bad6adcf12a51caa380_8_7)
      Toggle commit list
    Please register or sign in to reply
  • Đường Sỹ Hoàng @hoangds

    added 1 commit

    • 5ad6e140 - Fixed coding styles

    Compare with previous version

    Nov 21, 2019

    added 1 commit

    • 5ad6e140 - Fixed coding styles

    Compare with previous version

    added 1 commit * 5ad6e140 - Fixed coding styles [Compare with previous version](https://gitlab.zigexn.vn/hoangds/sample_app/merge_requests/12/diffs?diff_id=4377&start_sha=4348edead3ca4b1e58dd21ecb2515f0148a638d8)
    Toggle commit list
  • Đường Sỹ Hoàng @hoangds

    added 1 commit

    • d918dc16 - Removed unuse file

    Compare with previous version

    Nov 22, 2019

    added 1 commit

    • d918dc16 - Removed unuse file

    Compare with previous version

    added 1 commit * d918dc16 - Removed unuse file [Compare with previous version](https://gitlab.zigexn.vn/hoangds/sample_app/merge_requests/12/diffs?diff_id=4385&start_sha=5ad6e140d2bc2c8ba46e8720630bd5ce01cca01f)
    Toggle commit list
  • Đường Sỹ Hoàng @hoangds

    added 1 commit

    • 872b6844 - Fixed indentation

    Compare with previous version

    Nov 22, 2019

    added 1 commit

    • 872b6844 - Fixed indentation

    Compare with previous version

    added 1 commit * 872b6844 - Fixed indentation [Compare with previous version](https://gitlab.zigexn.vn/hoangds/sample_app/merge_requests/12/diffs?diff_id=4386&start_sha=d918dc1681b16c3b4d46ee732fcf24119a94a215)
    Toggle commit list
  • Đường Sỹ Hoàng @hoangds

    added 1 commit

    • 6a49f6f5 - Fixed coding styles

    Compare with previous version

    Nov 22, 2019

    added 1 commit

    • 6a49f6f5 - Fixed coding styles

    Compare with previous version

    added 1 commit * 6a49f6f5 - Fixed coding styles [Compare with previous version](https://gitlab.zigexn.vn/hoangds/sample_app/merge_requests/12/diffs?diff_id=4387&start_sha=872b684467e631f3c38dc093872b0191bc6e3150)
    Toggle commit list
  • Đường Sỹ Hoàng @hoangds

    added 15 commits

    • 6a49f6f5...3f81f3b1 - 7 commits from branch master
    • 02a3c78f - First commit
    • 1750253f - Removed unuse files
    • a605a688 - Removed newline
    • 643517bf - Removed newlines
    • 123f77ee - Fixed coding styles
    • 3097e5b5 - Removed unuse file
    • 183850cf - Fixed indentation
    • 1cf7b5ac - Fixed coding styles

    Compare with previous version

    Nov 22, 2019

    added 15 commits

    • 6a49f6f5...3f81f3b1 - 7 commits from branch master
    • 02a3c78f - First commit
    • 1750253f - Removed unuse files
    • a605a688 - Removed newline
    • 643517bf - Removed newlines
    • 123f77ee - Fixed coding styles
    • 3097e5b5 - Removed unuse file
    • 183850cf - Fixed indentation
    • 1cf7b5ac - Fixed coding styles

    Compare with previous version

    added 15 commits * 6a49f6f5...3f81f3b1 - 7 commits from branch `master` * 02a3c78f - First commit * 1750253f - Removed unuse files * a605a688 - Removed newline * 643517bf - Removed newlines * 123f77ee - Fixed coding styles * 3097e5b5 - Removed unuse file * 183850cf - Fixed indentation * 1cf7b5ac - Fixed coding styles [Compare with previous version](https://gitlab.zigexn.vn/hoangds/sample_app/merge_requests/12/diffs?diff_id=4388&start_sha=6a49f6f53ded9fa74f026b36e4989c7dfd204b90)
    Toggle commit list
  • Son Do Hong
    @sondh started a discussion on an old version of the diff Nov 22, 2019
    Last updated by Đường Sỹ Hoàng Nov 22, 2019
    app/controllers/users_controller.rb
    9 9
    10 10 def show
    11 11 @user = User.find(params[:id])
    12 <<<<<<< HEAD
    • Son Do Hong @sondh commented Nov 22, 2019
      Master

      fix conflict

      fix conflict
    • Đường Sỹ Hoàng @hoangds

      changed this line in version 8 of the diff

      Nov 22, 2019

      changed this line in version 8 of the diff

      changed this line in [version 8 of the diff](https://gitlab.zigexn.vn/hoangds/sample_app/merge_requests/12/diffs?diff_id=4389&start_sha=1cf7b5accd2a2b7e7e48021bd030c83e853b410a#28f48e0bc2718ddf87752d15b58a0016c13baf1c_12_12)
      Toggle commit list
    Please register or sign in to reply
  • Son Do Hong
    @sondh started a discussion on an old version of the diff Nov 22, 2019
    Last updated by Đường Sỹ Hoàng Nov 22, 2019
    app/models/relationship.rb 0 → 100644
    1 class Relationship < ApplicationRecord
    2 belongs_to :follower, class_name: "User"
    3 belongs_to :followed, class_name: "User"
    4
    5 validates :follower_id, presence: true
    6 validates :followed_id, presence: true
    7
    • Son Do Hong @sondh commented Nov 22, 2019
      Master

      xóa empty line

      xóa empty line
    • Đường Sỹ Hoàng @hoangds

      changed this line in version 8 of the diff

      Nov 22, 2019

      changed this line in version 8 of the diff

      changed this line in [version 8 of the diff](https://gitlab.zigexn.vn/hoangds/sample_app/merge_requests/12/diffs?diff_id=4389&start_sha=1cf7b5accd2a2b7e7e48021bd030c83e853b410a#96785831c7265ce81f5c694b2dd75eaf93be28f2_7_7)
      Toggle commit list
    Please register or sign in to reply
  • Son Do Hong
    @sondh started a discussion on an old version of the diff Nov 22, 2019
    Last updated by Đường Sỹ Hoàng Nov 22, 2019
    app/models/user.rb
    81 89 # Defines a proto-feed.
    82 90 # See "Following users" for the full implementation.
    83 91 def feed
    84 Micropost.where("user_id = ?", id)
    92 following_ids = "SELECT followed_id FROM relationships
    • Son Do Hong @sondh commented Nov 22, 2019
      Master

      viết lên 1 dòng

      viết lên 1 dòng
    • Đường Sỹ Hoàng @hoangds

      changed this line in version 8 of the diff

      Nov 22, 2019

      changed this line in version 8 of the diff

      changed this line in [version 8 of the diff](https://gitlab.zigexn.vn/hoangds/sample_app/merge_requests/12/diffs?diff_id=4389&start_sha=1cf7b5accd2a2b7e7e48021bd030c83e853b410a#4ed0c03b53dbc8320da88e7887465514cd9e90a4_92_92)
      Toggle commit list
    Please register or sign in to reply
  • Son Do Hong
    @sondh started a discussion on an old version of the diff Nov 22, 2019
    Last updated by Đường Sỹ Hoàng Nov 22, 2019
    app/models/user.rb
    81 89 # Defines a proto-feed.
    82 90 # See "Following users" for the full implementation.
    83 91 def feed
    84 Micropost.where("user_id = ?", id)
    92 following_ids = "SELECT followed_id FROM relationships
    93 WHERE follower_id = :user_id"
    94 Micropost.where("user_id IN (#{following_ids})
    95 OR user_id = :user_id", user_id: id)
    • Son Do Hong @sondh commented Nov 22, 2019
      Master

      viết lên cùng 1 dòng

      viết lên cùng 1 dòng
    • Đường Sỹ Hoàng @hoangds

      changed this line in version 8 of the diff

      Nov 22, 2019

      changed this line in version 8 of the diff

      changed this line in [version 8 of the diff](https://gitlab.zigexn.vn/hoangds/sample_app/merge_requests/12/diffs?diff_id=4389&start_sha=1cf7b5accd2a2b7e7e48021bd030c83e853b410a#4ed0c03b53dbc8320da88e7887465514cd9e90a4_95_92)
      Toggle commit list
    Please register or sign in to reply
  • Son Do Hong
    @sondh started a discussion on an old version of the diff Nov 22, 2019
    Last updated by Đường Sỹ Hoàng Nov 22, 2019
    app/views/users/edit.html.erb
    5 5
    6 6 <div class="row">
    7 7 <div class="col-md-6 col-md-offset-3">
    8 <<<<<<< HEAD
    • Son Do Hong @sondh commented Nov 22, 2019
      Master

      fix conflict

      fix conflict
    • Đường Sỹ Hoàng @hoangds

      changed this line in version 8 of the diff

      Nov 22, 2019

      changed this line in version 8 of the diff

      changed this line in [version 8 of the diff](https://gitlab.zigexn.vn/hoangds/sample_app/merge_requests/12/diffs?diff_id=4389&start_sha=1cf7b5accd2a2b7e7e48021bd030c83e853b410a#f341a6263d9803e768a000b11a0a610ffacae2eb_8_8)
      Toggle commit list
    Please register or sign in to reply
  • Đường Sỹ Hoàng @hoangds

    added 1 commit

    • 1292adb4 - Fixed conflict

    Compare with previous version

    Nov 22, 2019

    added 1 commit

    • 1292adb4 - Fixed conflict

    Compare with previous version

    added 1 commit * 1292adb4 - Fixed conflict [Compare with previous version](https://gitlab.zigexn.vn/hoangds/sample_app/merge_requests/12/diffs?diff_id=4389&start_sha=1cf7b5accd2a2b7e7e48021bd030c83e853b410a)
    Toggle commit list
  • Son Do Hong
    @sondh started a discussion on an old version of the diff Nov 22, 2019
    Last updated by Đường Sỹ Hoàng Nov 22, 2019
    app/views/users/edit.html.erb
    6 6 <div class="row">
    7 7 <div class="col-md-6 col-md-offset-3">
    8 8 <%= render "form" %>
    9 <div class="gravatar_edit">
    10 <%= gravatar_for @user %>
    11 <a href="http://gravatar.com/emails">change</a>
    9 <div class="gravatar_edit">
    • Son Do Hong @sondh commented Nov 22, 2019
      Master

      xem lại indent file này

      xem lại indent file này
    • Đường Sỹ Hoàng @hoangds

      changed this line in version 9 of the diff

      Nov 22, 2019

      changed this line in version 9 of the diff

      changed this line in [version 9 of the diff](https://gitlab.zigexn.vn/hoangds/sample_app/merge_requests/12/diffs?diff_id=4390&start_sha=1292adb4f2b45786192e51d1b6ec0a21a380c97c#f341a6263d9803e768a000b11a0a610ffacae2eb_9_9)
      Toggle commit list
    Please register or sign in to reply
  • Đường Sỹ Hoàng @hoangds

    added 1 commit

    • 49451d98 - Fixed indentation

    Compare with previous version

    Nov 22, 2019

    added 1 commit

    • 49451d98 - Fixed indentation

    Compare with previous version

    added 1 commit * 49451d98 - Fixed indentation [Compare with previous version](https://gitlab.zigexn.vn/hoangds/sample_app/merge_requests/12/diffs?diff_id=4390&start_sha=1292adb4f2b45786192e51d1b6ec0a21a380c97c)
    Toggle commit list
  • Son Do Hong @sondh

    mentioned in commit 1f48d01a

    Nov 22, 2019

    mentioned in commit 1f48d01a

    mentioned in commit 1f48d01a2b2f3b1424b73ba37470cf7055644b22
    Toggle commit list
  • Son Do Hong @sondh

    merged

    Nov 22, 2019

    merged

    merged
    Toggle commit list
  • Write
  • Preview
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or sign in to comment
Son Do Hong
Assignee
Son Do Hong @sondh
Assign to
None
Milestone
None
Assign milestone
Time tracking
2
2 participants
Reference: hoangds/sample_app!12
×

Revert this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.
×

Cherry-pick this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.