..

app/models/city.rb

@@ -2,6 +2,7 @@
 
 # Description/Explanation of Person class
 class City < ApplicationRecord
+  RANGE = 69
   has_many :city_jobs
   has_many :jobs, through: :city_jobs
   enum area: { international: 0, domestic: 1 }

app/models/company.rb

@@ -2,5 +2,6 @@
 
 # Description/Explanation of Person class
 class Company < ApplicationRecord
+  COMPANY_SECURITY = 1
   has_many :jobs
 end

lib/src/base/base.rb

@@ -6,8 +6,6 @@ require 'logger'
 
 # Crawler data
 class Base
-  COMPANY_SECURITY = 1
-
   attr_accessor :job, :page
 
   def initialize(page)
@@ -54,7 +52,7 @@ class Base
   end
 
   def fill_created_date
-    page.search('.item-blue .detail-box:nth-child(1) ul li:nth-child(1) p')[0].text
+    page.search('.item-blue .detail-box:nth-child(1) ul li:nth-child(1) p')[0].try(:text)
   end
 
   def fill_expiration_date
@@ -74,20 +72,16 @@ class Base
     job[:description] = page.search('.tabs .tab-content .detail-row').to_s
   end
 
-  def check
+  def exist_experience?
     noname = page.search('//ul//li').text
     noname.include?('Kinh nghiệm')
   end
 
   def fill_lever
-    if check
-      page.xpath('//ul//li[position()=3]//p')[1].text.strip
-    else
-      page.xpath('//ul//li[position()=2]//p')[1].text
-    end
+    exist_experience? ? page.xpath('//ul//li[position()=3]//p')[1].text.strip : page.xpath('//ul//li[position()=2]//p')[1].text
   end
 
   def fill_experience
-    check ? page.xpath('//ul//li[position()=2]//p')[1].text.strip : ''
+    exist_experience? ? page.xpath('//ul//li[position()=2]//p')[1].text.strip : ''
   end
 end

lib/src/crawler.rb

@@ -4,9 +4,6 @@ require 'open-uri'
 
 # Crawler data
 class Crawler
-  COMPANY_SECURITY = 1
-  RANGE = 69
-
   attr_accessor :number_link
 
   def initialize(number_link)
@@ -48,7 +45,7 @@ class Crawler
     page = Nokogiri::HTML(URI.open('https://careerbuilder.vn/viec-lam/tat-ca-viec-lam-vi.html'))
     locations = page.search('#location option').map(&:text)
     locations.each_with_index do |val, index|
-      area = index > RANGE ? City.areas['international'] : City.areas['domestic']
+      area = index > City::RANGE ? City.areas['international'] : City.areas['domestic']
       City.find_or_create_by(name: val) { |city| city.area = area }
     end
   end

lib/src/crawler_job.rb

@@ -45,7 +45,7 @@ class CrawlerJob < Crawler
   end
 
   def add_data(data)
-    id_company = (Company.find_by name: data[:company_name]).try(:id) || COMPANY_SECURITY
+    id_company = (Company.find_by name: data[:company_name]).try(:id) || Company::COMPANY_SECURITY
     job = Job.create(name: data[:name],
                      company_id: id_company,
                      level: data[:level],
@@ -61,8 +61,6 @@ class CrawlerJob < Crawler
   end
 
   def create_industry_relation(data, job)
-    return if data.blank? && id_job.blank?
-
     industries = data.split(',')
     industries.each do |val|
       val.gsub!('&amp;', '&') if val.include?('&amp;')

lib/src/interface/blue_interface.rb

@@ -10,8 +10,6 @@ class BlueInterface < Base
     page.search('.info-workplace .value a').map(&:text).join(',')
   end
 
-  def fill_created_date; end
-
   def fill_expiration_date
     page.xpath('//ul//li[position()=4]//div').text
   end
@@ -28,13 +26,13 @@ class BlueInterface < Base
     page.search('.left-col').to_s
   end
 
-  def check
+  def exist_level?
     noname = page.xpath('//ul//li[position()=2]/b').last.text
     noname.include?('Cấp bậc')
   end
 
   def fill_lever
-    check ? page.xpath('//ul//li[position()=2]/div').last.text : ''
+    exist_level? ? page.xpath('//ul//li[position()=2]/div').last.text : ''
   end
 
   def fill_experience

lib/src/interface/green_interface.rb

@@ -14,8 +14,6 @@ class GreenInterface < Base
     page.search('.DetailJobNew ul li:nth-child(1) a').text
   end
 
-  def fill_created_date; end
-
   def fill_expiration_date
     page.xpath('//ul//li[last()-1]//span').children[1].text
   end
@@ -36,12 +34,12 @@ class GreenInterface < Base
     page.search('.DetailJobNew li:nth-child(2) span').text.strip
   end
 
-  def check_exp
+  def exist_experience?
     noname = page.search('.DetailJobNew li span').text
     noname.include?('Kinh nghiệm')
   end
 
   def fill_experience
-    check_exp ? page.search('.DetailJobNew li:nth-child(5) span').text.strip : ''
+    exist_experience? ? page.search('.DetailJobNew li:nth-child(5) span').text.strip : ''
   end
 end

lib/tasks/crawler.rake

@@ -5,7 +5,7 @@ require 'open-uri'
 # rake task
 namespace :crawler do
   task populate: :environment do
-    NUMBER_LINK_WILL_BE_CRAWLER = 100
+    NUMBER_LINK_WILL_BE_CRAWLER = 5
     Company.find_or_create_by(name: 'Bảo mật') do |company|
       company.address = 'Vui lòng xem trong mô tả công việc'
       company.short_description = 'Vui lòng xem trong mô tả công việc'