Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
V
venjob_nth
  • Overview
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 3
    • Merge Requests 3
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Ngô Trung Hưng
  • venjob_nth
  • Merge Requests
  • !6

Merged
Opened Aug 04, 2020 by Ngô Trung Hưng@hungnt 
  • Report abuse
Report abuse

create job list

×

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch origin
git checkout -b joblist origin/joblist

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git checkout master
git merge --no-ff joblist

Step 4. Push the result of the merge to GitLab

git push origin master

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

  • Discussion 16
  • Commits 11
  • Pipelines 11
  • Changes 41
{{ resolvedDiscussionCount }}/{{ discussionCount }} {{ resolvedCountText }} resolved
  • Ngô Trung Hưng @hungnt

    added 1 commit

    • 1342036a - fix render partial

    Compare with previous version

    Aug 04, 2020

    added 1 commit

    • 1342036a - fix render partial

    Compare with previous version

    added 1 commit * 1342036a - fix render partial [Compare with previous version](https://gitlab.zigexn.vn/hungnt/venjob_nth/merge_requests/6/diffs?diff_id=4939&start_sha=472bd1dffa4a7284958ba8fd4032d261a21ca894)
    Toggle commit list
  • Ngô Trung Hưng @hungnt

    added 1 commit

    • c4c3b235 - ..

    Compare with previous version

    Aug 05, 2020

    added 1 commit

    • c4c3b235 - ..

    Compare with previous version

    added 1 commit * c4c3b235 - .. [Compare with previous version](https://gitlab.zigexn.vn/hungnt/venjob_nth/merge_requests/6/diffs?diff_id=4942&start_sha=1342036a96c5e9f293ec6efa42ed549104e515e0)
    Toggle commit list
  • Ngô Trung Hưng @hungnt

    added 1 commit

    • c5eb1f47 - ..

    Compare with previous version

    Aug 05, 2020

    added 1 commit

    • c5eb1f47 - ..

    Compare with previous version

    added 1 commit * c5eb1f47 - .. [Compare with previous version](https://gitlab.zigexn.vn/hungnt/venjob_nth/merge_requests/6/diffs?diff_id=4944&start_sha=c4c3b235e0dca4be22c77887ed4faeed0d44cae7)
    Toggle commit list
  • Ngô Trung Hưng @hungnt

    added 1 commit

    • 4036163b - ..

    Compare with previous version

    Aug 05, 2020

    added 1 commit

    • 4036163b - ..

    Compare with previous version

    added 1 commit * 4036163b - .. [Compare with previous version](https://gitlab.zigexn.vn/hungnt/venjob_nth/merge_requests/6/diffs?diff_id=4945&start_sha=c5eb1f471c1697133c5a627c2d8a51f76961a2ad)
    Toggle commit list
  • Ngô Trung Hưng @hungnt

    added 1 commit

    • 6d4d7392 - ..

    Compare with previous version

    Aug 05, 2020

    added 1 commit

    • 6d4d7392 - ..

    Compare with previous version

    added 1 commit * 6d4d7392 - .. [Compare with previous version](https://gitlab.zigexn.vn/hungnt/venjob_nth/merge_requests/6/diffs?diff_id=4950&start_sha=4036163bad67a9f6f3f967a10b60ce1bfe79517d)
    Toggle commit list
  • Ngô Trung Hưng @hungnt

    added 1 commit

    • d4ef13ab - fix conflc

    Compare with previous version

    Aug 05, 2020

    added 1 commit

    • d4ef13ab - fix conflc

    Compare with previous version

    added 1 commit * d4ef13ab - fix conflc [Compare with previous version](https://gitlab.zigexn.vn/hungnt/venjob_nth/merge_requests/6/diffs?diff_id=4952&start_sha=6d4d7392c869529d953df063c42d1c9b076ff51c)
    Toggle commit list
  • Ngô Trung Hưng @hungnt

    added 1 commit

    • 39a4990a - joblist beta

    Compare with previous version

    Aug 06, 2020

    added 1 commit

    • 39a4990a - joblist beta

    Compare with previous version

    added 1 commit * 39a4990a - joblist beta [Compare with previous version](https://gitlab.zigexn.vn/hungnt/venjob_nth/merge_requests/6/diffs?diff_id=4955&start_sha=d4ef13ab766a827e62670107dd5096e25a541029)
    Toggle commit list
  • Hoang Phuc Do
    @phucdh started a discussion on an old version of the diff Aug 06, 2020
    Resolved by Ngô Trung Hưng Aug 06, 2020
    app/views/job/_block_info_job.html.erb 0 → 100644
    1 <%cru = 0%>
    2 <div class="container">
    3 <div class="row">
    4 <div class="col-sm-12">
    5 <div class="box_jobs">
    6 <div class="col-sm-12 d-block d-sm-none">
    7 <% if cru == 1 %>
    • Hoang Phuc Do @phucdh commented Aug 06, 2020
      Master

      Giá trị cru có vẻ luôn luôn là 0, dòng này có tác dụng không ?

      Edited Aug 06, 2020
      Giá trị `cru` có vẻ luôn luôn là 0, dòng này có tác dụng không ?
    • Ngô Trung Hưng @hungnt

      changed this line in version 9 of the diff

      Aug 06, 2020

      changed this line in version 9 of the diff

      changed this line in [version 9 of the diff](https://gitlab.zigexn.vn/hungnt/venjob_nth/merge_requests/6/diffs?diff_id=4957&start_sha=39a4990a8b1a361dbd39cfb9a2cee21a5caaf0b9#a5a13672e91fdd4ff6b1a307c1a140709aed1452_7_5)
      Toggle commit list
    Please register or sign in to reply
  • Hoang Phuc Do
    @phucdh started a discussion on an old version of the diff Aug 06, 2020
    Last updated by Ngô Trung Hưng Aug 06, 2020
    app/views/job/_block_info_job.html.erb 0 → 100644
    17 <div class="row">
    18 <div class="col-sm-10 col-md-9 col-lg-10">
    19 <div class="box_info">
    20 <div class="lol">
    21 <%= link_to data.name, '#', class: 'job_name' %>
    22 </div>
    23 <div class="cop">
    24 <h5 class="box_info_copany_name"><i class="far fa-building"></i> <%= data.company.name %></h5>
    25 </div>
    26 <div class="loc">
    27 <h5 class="box_info_location"><i class="fas fa-map-marker-alt"></i>
    28 <% dt = [] %>
    29 <% data.cities.each do |x| %>
    30 <% dt << (x.name << ' | ') %>
    31 <% end %>
    32 <%= dt.join('').chomp('| ')%>
    • Hoang Phuc Do @phucdh commented Aug 06, 2020
      Master

      Cách viết như thế này có cho ra kết quả tương tự không ?

      Ngắn hơn và dùng ít method hơn

      data.cities.map(&:name).join(' | ')
      Edited Aug 06, 2020 by Hoang Phuc Do
      Cách viết như thế này có cho ra kết quả tương tự không ? Ngắn hơn và dùng ít method hơn ```ruby data.cities.map(&:name).join(' | ') ```
    • Ngô Trung Hưng @hungnt commented Aug 06, 2020
      Master

      Thanks anh

      Edited Aug 06, 2020
      Thanks anh
    • Ngô Trung Hưng @hungnt

      changed this line in version 9 of the diff

      Aug 06, 2020

      changed this line in version 9 of the diff

      changed this line in [version 9 of the diff](https://gitlab.zigexn.vn/hungnt/venjob_nth/merge_requests/6/diffs?diff_id=4957&start_sha=39a4990a8b1a361dbd39cfb9a2cee21a5caaf0b9#a5a13672e91fdd4ff6b1a307c1a140709aed1452_32_21)
      Toggle commit list
    Please register or sign in to reply
  • Hoang Phuc Do
    @phucdh started a discussion on an old version of the diff Aug 06, 2020
    Last updated by Ngô Trung Hưng Aug 06, 2020
    app/views/job/_block_info_job.html.erb 0 → 100644
    30 <% dt << (x.name << ' | ') %>
    31 <% end %>
    32 <%= dt.join('').chomp('| ')%>
    33 </h5>
    34 </div>
    35 <h5 class="box_info_salary"><i class="fas fa-dollar-sign"></i>&nbsp; Lương: <%= data.salary %></h5>
    36 <div class="coc">
    37 <h5 class="box_info_des"><%= strip_tags(data.description) %></h5>
    38 </div>
    39 </div>
    40 </div>
    41 <div class="col-sm-2 col-md-3 d-none d-sm-block col-lg-2">
    42 <% if cru == 1 %>
    43 <div class="box_link_favotite">
    44 <div class="block_link_favorite lg">
    45 <span><i class="far fa-heart"></i> <%= link_to 'Yêu thích'.html_safe,'#',class: 'link_favorite'%><span>
    • Hoang Phuc Do @phucdh commented Aug 06, 2020
      Master

      Sau dấu ',' phải có khoảng trắng

      Kiểm tra và sửa lại các chỗ tương tự

      Edited Aug 06, 2020
      Sau dấu ',' phải có khoảng trắng Kiểm tra và sửa lại các chỗ tương tự
    • Ngô Trung Hưng @hungnt commented Aug 06, 2020
      Master

      Dạ anh

      Edited Aug 06, 2020
      Dạ anh
    • Ngô Trung Hưng @hungnt

      changed this line in version 9 of the diff

      Aug 06, 2020

      changed this line in version 9 of the diff

      changed this line in [version 9 of the diff](https://gitlab.zigexn.vn/hungnt/venjob_nth/merge_requests/6/diffs?diff_id=4957&start_sha=39a4990a8b1a361dbd39cfb9a2cee21a5caaf0b9#a5a13672e91fdd4ff6b1a307c1a140709aed1452_45_30)
      Toggle commit list
    Please register or sign in to reply
  • Hoang Phuc Do
    @phucdh started a discussion on an old version of the diff Aug 06, 2020
    Last updated by Ngô Trung Hưng Aug 06, 2020
    app/views/job/result_data.html.erb 0 → 100644
    1 <% provide(:title ,'Kết quả tìm kiếm') %>
    2 <%= render 'home/banner_and_search' %>
    3 <div class="padding_index"></div>
    4 <div class="container">
    5 <div class="row">
    6 <div class="col-lg-12">
    7 <div class="breadcrumb_total_search">
    8 <span class="breadcrumb-item active">
    9 Có&nbsp;<b><%= @data.total_count %></b>&nbsp;kết quả phù hợp với từ khóa&nbsp;<b><%= @keyword %></b>&nbsp;
    • Hoang Phuc Do @phucdh commented Aug 06, 2020
      Master

      Nếu @data.total_count trả về 0 thì nên hiện đoạn thông báo khác

      Nếu `@data.total_count` trả về 0 thì nên hiện đoạn thông báo khác
    • Ngô Trung Hưng @hungnt

      changed this line in version 9 of the diff

      Aug 06, 2020

      changed this line in version 9 of the diff

      changed this line in [version 9 of the diff](https://gitlab.zigexn.vn/hungnt/venjob_nth/merge_requests/6/diffs?diff_id=4957&start_sha=39a4990a8b1a361dbd39cfb9a2cee21a5caaf0b9#3a59bf29b177ecf20da49e0fcaaf5de1cda03a58_9_9)
      Toggle commit list
    Please register or sign in to reply
  • Hoang Phuc Do
    @phucdh started a discussion on an old version of the diff Aug 06, 2020
    Last updated by Ngô Trung Hưng Aug 06, 2020
    app/views/home/_banner_and_search.html.erb
    28 28 <input type="search" name="" id="" class="custom_input_search" placeholder="Nhập tiêu đề, công ty, địa điểm...">
    29 29 </div>
    30 30 <div class="search_industries">
    31 <div class="icon_list">
    32 <i class="fa fa-list-ul" aria-hidden="true"></i>
    33 </div>
    34 <select class="show_list_industries">
    35 <option value="*" selected disabled hidden class="select_first">Tất cả ngành nghề</option>
    36 <% @industries.each do |val| %>
    37 <option value="<%= val.id %>"><%= val.name %></option>
    38 <% end %>
    39 </select>
    31 <div class="icon_list">
    32 <i class="fa fa-list-ul" aria-hidden="true"></i>
    33 </div>
    34 <%= select_tag 'industry', options_from_collection_for_select(@industries, "id", "name"), class: 'show_list_industries' %>
    • Hoang Phuc Do @phucdh commented Aug 06, 2020
      Master

      Kiểm tra lại trường hợp dùng nháy đơn " và nháy kép '

      Kiểm tra lại trường hợp dùng nháy đơn " và nháy kép '
    • Ngô Trung Hưng @hungnt commented Aug 06, 2020
      Master

      dạ

      dạ
    • Ngô Trung Hưng @hungnt

      changed this line in version 9 of the diff

      Aug 06, 2020

      changed this line in version 9 of the diff

      changed this line in [version 9 of the diff](https://gitlab.zigexn.vn/hungnt/venjob_nth/merge_requests/6/diffs?diff_id=4957&start_sha=39a4990a8b1a361dbd39cfb9a2cee21a5caaf0b9#513a566925d2d34acd597278c002c3f59fa128d6_34_34)
      Toggle commit list
    Please register or sign in to reply
  • Hoang Phuc Do
    @phucdh started a discussion on an old version of the diff Aug 06, 2020
    Last updated by Ngô Trung Hưng Aug 06, 2020
    app/models/city.rb
    13 15 .order(Arel.sql('count(jobs.id) DESC'))
    14 16 .take(number)
    15 17 end
    18
    19 def convert_to_slug
    20 self.slug = Slug.to_slug(self.name + ' ' + rand(10000).to_s)
    • Hoang Phuc Do @phucdh commented Aug 06, 2020
      Master
      Slug.to_slug("#{name} #{rand(10000)}")

      Sửa lại những chỗ tương tự

      Edited Aug 06, 2020 by Hoang Phuc Do
      ```ruby Slug.to_slug("#{name} #{rand(10000)}") ``` Sửa lại những chỗ tương tự
    • Ngô Trung Hưng @hungnt commented Aug 06, 2020
      Master

      dạ

      dạ
    • Ngô Trung Hưng @hungnt

      changed this line in version 9 of the diff

      Aug 06, 2020

      changed this line in version 9 of the diff

      changed this line in [version 9 of the diff](https://gitlab.zigexn.vn/hungnt/venjob_nth/merge_requests/6/diffs?diff_id=4957&start_sha=39a4990a8b1a361dbd39cfb9a2cee21a5caaf0b9#28495972e963898abf2919ffeaeb92fbdf49fb8e_20_20)
      Toggle commit list
    Please register or sign in to reply
  • Hoang Phuc Do
    @phucdh started a discussion on an old version of the diff Aug 06, 2020
    Last updated by Ngô Trung Hưng Aug 06, 2020
    app/common/slug.rb 0 → 100644
    9 %w[ù ú ụ ủ ũ ư ừ ứ ự ử ữ] => 'u',
    10 %w[ỳ ý ỵ ỷ ỹ] => 'y',
    11 %w[đ] => 'd'
    12 }
    13
    14 accents.each do |ac, rep|
    15 ac.each do |s|
    16 str = str.tr(s, rep)
    17 end
    18 end
    19
    20 str = str.gsub(/[^a-zA-Z0-9 ]/, '')
    21 str = str.gsub(/[ ]+/, ' ')
    22 str.tr(' ', '-')
    23 end
    24 end
    • Hoang Phuc Do @phucdh commented Aug 06, 2020
      Master

      Thêm dòng trống vào cuối file

      Thêm dòng trống vào cuối file
    • Ngô Trung Hưng @hungnt commented Aug 06, 2020
      Master

      dạ anh

      dạ anh
    • Ngô Trung Hưng @hungnt

      changed this line in version 9 of the diff

      Aug 06, 2020

      changed this line in version 9 of the diff

      changed this line in [version 9 of the diff](https://gitlab.zigexn.vn/hungnt/venjob_nth/merge_requests/6/diffs?diff_id=4957&start_sha=39a4990a8b1a361dbd39cfb9a2cee21a5caaf0b9#5560f33c53f1650775c559b9916bba4d38008870_24_27)
      Toggle commit list
    Please register or sign in to reply
  • Hoang Phuc Do
    @phucdh started a discussion on the diff Aug 06, 2020
    Last updated by Ngô Trung Hưng Aug 06, 2020
    app/controllers/job_controller.rb
    2 2
    3 3 # Job controller
    4 4 class JobController < ApplicationController
    5 before_action :load_data_dropdown, only: :index
    6
    7 def index
    8 model = params[:model].classify.constantize
    • Hoang Phuc Do @phucdh commented Aug 06, 2020
      Master

      Nếu params[:model].classify.constantize trả về một class không tồn tại thì thế nào

      Nếu `params[:model].classify.constantize` trả về một class không tồn tại thì thế nào
    • Ngô Trung Hưng @hungnt commented Aug 06, 2020
      Master

      nếu mà url truyền params sai vào e định viết thểm controller để bắt các lỗi như 404 với 500

      nếu mà url truyền params sai vào e định viết thểm controller để bắt các lỗi như 404 với 500
    Please register or sign in to reply
  • Hoang Phuc Do
    @phucdh started a discussion on an old version of the diff Aug 06, 2020
    Last updated by Ngô Trung Hưng Aug 06, 2020
    app/controllers/job_controller.rb
    5 before_action :load_data_dropdown, only: :index
    6
    7 def index
    8 model = params[:model].classify.constantize
    9 obj = model.find_by(slug: params[:slug])
    10 result(obj)
    11 end
    12
    13 private
    14
    15 def load_data_dropdown
    16 @industries = Industry.order(name: :asc).all
    17 @cities = City.select(:id, :name)
    18 end
    19
    20 def result(obj)
    • Hoang Phuc Do @phucdh commented Aug 06, 2020
      Master

      Nên bắt đầu bằng một động từ, ví dụ

      render_result
      Nên bắt đầu bằng một động từ, ví dụ ```ruby render_result ```
    • Ngô Trung Hưng @hungnt commented Aug 06, 2020
      Master

      dạ anh

      dạ anh
    • Ngô Trung Hưng @hungnt

      changed this line in version 9 of the diff

      Aug 06, 2020

      changed this line in version 9 of the diff

      changed this line in [version 9 of the diff](https://gitlab.zigexn.vn/hungnt/venjob_nth/merge_requests/6/diffs?diff_id=4957&start_sha=39a4990a8b1a361dbd39cfb9a2cee21a5caaf0b9#190c719ee71b0ae6c668db31423f9092e2c936d7_20_20)
      Toggle commit list
    Please register or sign in to reply
  • Ngô Trung Hưng @hungnt

    added 1 commit

    • d66ca2b0 - add page 404

    Compare with previous version

    Aug 06, 2020

    added 1 commit

    • d66ca2b0 - add page 404

    Compare with previous version

    added 1 commit * d66ca2b0 - add page 404 [Compare with previous version](https://gitlab.zigexn.vn/hungnt/venjob_nth/merge_requests/6/diffs?diff_id=4957&start_sha=39a4990a8b1a361dbd39cfb9a2cee21a5caaf0b9)
    Toggle commit list
  • Ngô Trung Hưng @hungnt

    added 1 commit

    • 125cc119 - fix name method page_not_found

    Compare with previous version

    Aug 06, 2020

    added 1 commit

    • 125cc119 - fix name method page_not_found

    Compare with previous version

    added 1 commit * 125cc119 - fix name method page_not_found [Compare with previous version](https://gitlab.zigexn.vn/hungnt/venjob_nth/merge_requests/6/diffs?diff_id=4958&start_sha=d66ca2b0f41e8607d81cfff6202b4e170161d871)
    Toggle commit list
  • Ngô Trung Hưng @hungnt

    added 16 commits

    • 125cc119...c5992cdd - 15 commits from branch master
    • 14033567 - Merge branch 'master' into 'joblist'

    Compare with previous version

    Aug 06, 2020

    added 16 commits

    • 125cc119...c5992cdd - 15 commits from branch master
    • 14033567 - Merge branch 'master' into 'joblist'

    Compare with previous version

    added 16 commits * 125cc119...c5992cdd - 15 commits from branch `master` * 14033567 - Merge branch &#x27;master&#x27; into &#x27;joblist&#x27; [Compare with previous version](https://gitlab.zigexn.vn/hungnt/venjob_nth/merge_requests/6/diffs?diff_id=4960&start_sha=125cc11951a96d0e0e94d93806a960a91591a4e2)
    Toggle commit list
  • Hoang Phuc Do @phucdh

    mentioned in commit 6c47054b

    Aug 06, 2020

    mentioned in commit 6c47054b

    mentioned in commit 6c47054bbd7a7011c5a679179d7d48aa2ec74df7
    Toggle commit list
  • Hoang Phuc Do @phucdh

    merged

    Aug 06, 2020

    merged

    merged
    Toggle commit list
  • Write
  • Preview
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or sign in to comment
Assignee
No assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
2
2 participants
Reference: hungnt/venjob_nth!6
×

Revert this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.
×

Cherry-pick this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.