Fix comment - Check signed in by controller

app/controllers/jobs_controller.rb

@@ -52,9 +52,10 @@ class JobsController < ApplicationController
   end
 
   def favorite
-    @job_id = params[:job_id]
-    job = Job.find(@job_id)
-    Favorite.new(user: current_user, job: job).save if Favorite.where(user: current_user, job: job).blank?
+    redirect_to new_user_session_path unless user_signed_in?
+
+    @job = Job.find(params[:job_id])
+    Favorite.new(user: current_user, job: @job).save if Favorite.where(user: current_user, job: @job).blank?
   end
 
   def favorite_remove
@@ -64,11 +65,15 @@ class JobsController < ApplicationController
   end
 
   def favorited_jobs
+    redirect_to new_user_session_path unless user_signed_in?
+
     @favorited_jobs = Favorite.where(user: current_user)
 
   end
 
   def history_jobs
+    redirect_to new_user_session_path unless user_signed_in?
+
     @history_jobs = History.all
   end
 end

app/views/jobs/favorite.js.erb

-$("#favorite_<%= @job_id %>").remove()
+$("#favorite_<%= @job.id %>").remove()

app/views/jobs/index.html.erb

@@ -36,12 +36,7 @@
           <td>
             <% if Favorite.where(user: current_user, job: job).blank? %>
               <div class="col-md-3" id="favorite_<%= job.id %>">
-                <% if user_signed_in? %>
-                  <%= link_to 'Favorite', jobs_favorite_path(job_id: job.id, format: 'js'), remote: true, class: 'favorite_add' %>
-                <% else %>
-                  <%= link_to 'Favorite', new_user_session_path %>
-                <% end %>
-                <input type="hidden" id="job_id" name="job_id" value="<%= job.id %>">
+                <%= link_to 'Favorite', jobs_favorite_path(job_id: job.id, format: 'js'), remote: true, class: 'favorite_add' %>
               </div>
             <% end %>
           </td>

app/views/layouts/_header.html.erb

@@ -6,14 +6,12 @@
         <% if user_signed_in? %>
           <li> <%= link_to 'My profile', registrations_show_path %> </li>
           <li> <%= link_to 'Log out', destroy_user_session_path, method: :delete %> </li>
-          <li> <%= link_to 'Favorite', jobs_favorited_jobs_path %> </li>
-          <li> <%= link_to 'History', jobs_history_jobs_path %> </li>
         <% else %>
           <li> <%= link_to 'Login', new_user_session_path %> </li>
           <li> <%= link_to 'Register', new_user_registration_path %> </li>
-          <li> <%= link_to 'Favorite', new_user_session_path %> </li>
-          <li> <%= link_to 'History', new_user_session_path %> </li>
         <% end %>
+        <li> <%= link_to 'Favorite', jobs_favorited_jobs_path %> </li>
+        <li> <%= link_to 'History', jobs_history_jobs_path %> </li>
       </ul>
     </nav>
   </div>