Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
T
ThaiMinhPhuc_training
  • Overview
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • phuctmZigexn
  • ThaiMinhPhuc_training
  • Merge Requests
  • !7

Merged
Opened Aug 06, 2018 by phuctmZigexn@phuctm 
  • Report abuse
Report abuse

Implement basic login

  • Discussion 2
  • Commits 1
  • Changes 19
{{ resolvedDiscussionCount }}/{{ discussionCount }} {{ resolvedCountText }} resolved
  • Ba Toi Dang
    @toidb started a discussion on the diff Aug 06, 2018
    test/integration/users_signup_test.rb
    10 10 password_confirmation: "bar" } }
    11 11 end
    12 12 assert_template 'users/new'
    13 assert_select 'div#<CSS id for error explanation>'
    • Ba Toi Dang @toidb commented Aug 06, 2018
      Master

      @phuctm please keep old unit test. You must update it instead of removing.

      @phuctm please keep old unit test. You must update it instead of removing.
    Please register or sign in to reply
  • Ba Toi Dang
    @toidb started a discussion on the diff Aug 06, 2018
    app/views/users/new.html.erb
    3 3
    4 4 <div class="row">
    5 5 <div class="col-md-6 col-md-offet-3">
    6 <%= form_for @user, url: signup_path do |f| %>
    • Ba Toi Dang @toidb commented Aug 06, 2018
      Master

      @phuctm why you remove url: signup_path?

      @phuctm why you remove `url: signup_path`?
    Please register or sign in to reply
  • Ba Toi Dang @toidb

    mentioned in commit 600940ba

    Aug 06, 2018

    mentioned in commit 600940ba

    mentioned in commit 600940ba309100607d55a815b36dfbd2b4f16fd9
    Toggle commit list
  • Ba Toi Dang @toidb

    merged

    Aug 06, 2018

    merged

    merged
    Toggle commit list
  • Ba Toi Dang @toidb

    mentioned in commit cb5fb361

    Aug 06, 2018

    mentioned in commit cb5fb361

    mentioned in commit cb5fb361cd778a0f6e3776112cf55c0ec5a87459
    Toggle commit list
  • Ba Toi Dang @toidb

    mentioned in merge request !8 (merged)

    Aug 06, 2018

    mentioned in merge request !8 (merged)

    mentioned in merge request !8
    Toggle commit list
  • Write
  • Preview
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or sign in to comment
Assignee
No assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
2
2 participants
Reference: phuctm/ThaiMinhPhuc_training!7
×

Cherry-pick this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.