Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
V
venjob
  • Overview
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Huỳnh Thiên Phước
  • venjob
  • Merge Requests
  • !5

Closed
Opened Aug 11, 2020 by Huỳnh Thiên Phước@phuocht 
  • Report abuse
Report abuse

Job list

×

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch origin
git checkout -b job_list origin/job_list

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git checkout master
git merge --no-ff job_list

Step 4. Push the result of the merge to GitLab

git push origin master

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

  • Discussion 16
  • Commits 16
  • Pipelines 3
  • Changes 45
{{ resolvedDiscussionCount }}/{{ discussionCount }} {{ resolvedCountText }} resolved
  • Van Hau Le
    @haulv started a discussion on the diff Aug 11, 2020
    Last updated by Van Hau Le Aug 13, 2020
    app/common/convert.rb 0 → 100644
    1 module Convert
    • Van Hau Le @haulv commented Aug 11, 2020
      Master

      @phuocht này bỏ vào ApplicationRecord hoặc Helper đi em. KO cần tách module vậy đâu

      @phuocht này bỏ vào `ApplicationRecord` hoặc Helper đi em. KO cần tách module vậy đâu
    • Huỳnh Thiên Phước @phuocht commented Aug 11, 2020
      Master

      dạ v. để xíu e bỏ vào helper

      dạ v. để xíu e bỏ vào helper
    • Van Hau Le @haulv commented Aug 13, 2020
      Master

      @phuocht file này đâu cần nữa đâu em

      @phuocht file này đâu cần nữa đâu em
    Please register or sign in to reply
  • Van Hau Le
    @haulv started a discussion on the diff Aug 11, 2020
    Last updated by Huỳnh Thiên Phước Aug 11, 2020
    app/controllers/jobs_controller.rb
    1 1 class JobsController < ApplicationController
    2 before_action :use_variables
    3
    2 4 def index
    3 @total_job = Job.count
    4 @jobs_list = Job.all_job
    5 @jobs_list = Job.all_job.page(params[:page]).per(20)
    • Van Hau Le @haulv commented Aug 11, 2020
      Master

      @phuocht mấy con số 20 này nên move ra thành constant hay setting nhe em, ko hard code như vậy

      @phuocht mấy con số 20 này nên move ra thành constant hay setting nhe em, ko hard code như vậy
    • Huỳnh Thiên Phước @phuocht commented Aug 11, 2020
      Master

      ok, a v. e check mấy cái số => constant variables hết

      ok, a v. e check mấy cái số => constant variables hết
    Please register or sign in to reply
  • Van Hau Le
    @haulv started a discussion on the diff Aug 11, 2020
    Last updated by Van Hau Le Aug 13, 2020
    app/controllers/jobs_controller.rb
    1 1 class JobsController < ApplicationController
    2 before_action :use_variables
    3
    2 4 def index
    3 @total_job = Job.count
    4 @jobs_list = Job.all_job
    5 @jobs_list = Job.all_job.page(params[:page]).per(20)
    6 end
    7
    8 def city_jobs
    9 @city = City.find_by(converted_name: params[:converted_name])
    10 @jobs_list = @city.jobs.all_job.page(params[:page]).per(20)
    • Van Hau Le @haulv commented Aug 11, 2020
      Master

      @phuocht tại sao phải dùng @jobs_list = @city.jobs.all_job.page(params[:page]).per(20)? DÙng thế này được ko? @jobs_list = @city.jobs.page(params[:page]).per(20)

      @phuocht tại sao phải dùng `@jobs_list = @city.jobs.all_job.page(params[:page]).per(20)`? DÙng thế này được ko? `@jobs_list = @city.jobs.page(params[:page]).per(20)`
    • Huỳnh Thiên Phước @phuocht commented Aug 11, 2020
      Master

      dạ được a :D

      dạ được a :D
    • Van Hau Le @haulv commented Aug 13, 2020
      Master

      @phuocht chưa fix hả em

      @phuocht chưa fix hả em
    Please register or sign in to reply
  • Van Hau Le
    @haulv started a discussion on the diff Aug 11, 2020
    app/controllers/jobs_controller.rb
    3
    2 4 def index
    3 @total_job = Job.count
    4 @jobs_list = Job.all_job
    5 @jobs_list = Job.all_job.page(params[:page]).per(20)
    6 end
    7
    8 def city_jobs
    9 @city = City.find_by(converted_name: params[:converted_name])
    10 @jobs_list = @city.jobs.all_job.page(params[:page]).per(20)
    11 @result_for_job = @city.jobs.count
    12 end
    13
    14 def industry_jobs
    15 @industry = Industry.find_by(converted_name: params[:converted_name])
    16 @jobs_list = @industry.jobs.all_job.page(params[:page]).per(20)
    • Van Hau Le @haulv commented Aug 11, 2020
      Master

      @phuocht tương tự bên trên

      @phuocht tương tự bên trên
    Please register or sign in to reply
  • Van Hau Le
    @haulv started a discussion on the diff Aug 11, 2020
    Last updated by Huỳnh Thiên Phước Aug 11, 2020
    app/controllers/jobs_controller.rb
    16 @jobs_list = @industry.jobs.all_job.page(params[:page]).per(20)
    17 @result_for_job = @industry.jobs.count
    18 end
    19
    20 def company_jobs
    21 @company = Company.find_by(converted_name: params[:converted_name])
    22 @jobs_list = @company.jobs.all_job.page(params[:page]).per(20)
    23 @result_for_job = @company.jobs.count
    24 end
    25
    26 def detail
    27 @job_details = Job.find(params[:id])
    28 end
    29
    30 def use_variables
    5 31 @cities = City.all
    • Van Hau Le @haulv commented Aug 11, 2020
      Master

      @phuocht method này để làm gì vậy e?

      @phuocht method này để làm gì vậy e?
    • Huỳnh Thiên Phước @phuocht commented Aug 11, 2020
      Master

      để e dùng chung mấy biến instance đó a

      để e dùng chung mấy biến instance đó a
    Please register or sign in to reply
  • Van Hau Le
    @haulv started a discussion on the diff Aug 11, 2020
    Last updated by Van Hau Le Aug 11, 2020
    app/models/company.rb
    1 1 class Company < ApplicationRecord
    2 before_save :convert_company
    2 3 has_many :jobs
    4
    5 def convert_company
    • Van Hau Le @haulv commented Aug 11, 2020
      Master

      @phuocht method này đều chung mục đích, chung cách thực hiện cho tất cả model có liên quan. Move nó vào ApplicationRecord đi em

      @phuocht method này đều chung mục đích, chung cách thực hiện cho tất cả model có liên quan. Move nó vào `ApplicationRecord` đi em
    • Huỳnh Thiên Phước @phuocht commented Aug 11, 2020
      Master

      dạ ok e bỏ city, company với industry vào a. Tại job e ko lấy column name mà lấy column title @haulv

      dạ ok e bỏ city, company với industry vào a. Tại job e ko lấy column name mà lấy column title @haulv
    • Van Hau Le @haulv commented Aug 11, 2020
      Master

      @phuocht truyền field name vào

      @phuocht truyền field name vào
    Please register or sign in to reply
  • Van Hau Le
    @haulv started a discussion on the diff Aug 11, 2020
    app/controllers/jobs_controller.rb
    11 @result_for_job = @city.jobs.count
    12 end
    13
    14 def industry_jobs
    15 @industry = Industry.find_by(converted_name: params[:converted_name])
    16 @jobs_list = @industry.jobs.all_job.page(params[:page]).per(20)
    17 @result_for_job = @industry.jobs.count
    18 end
    19
    20 def company_jobs
    21 @company = Company.find_by(converted_name: params[:converted_name])
    22 @jobs_list = @company.jobs.all_job.page(params[:page]).per(20)
    23 @result_for_job = @company.jobs.count
    24 end
    25
    26 def detail
    • Van Hau Le @haulv commented Aug 11, 2020
      Master

      @phuocht def show. Dùng action có sẵn theo convention của Rails nhe e!

      @phuocht `def show`. Dùng action có sẵn theo convention của Rails nhe e!
    Please register or sign in to reply
  • Van Hau Le
    @haulv started a discussion on the diff Aug 11, 2020
    app/controllers/jobs_controller.rb
    12 end
    13
    14 def industry_jobs
    15 @industry = Industry.find_by(converted_name: params[:converted_name])
    16 @jobs_list = @industry.jobs.all_job.page(params[:page]).per(20)
    17 @result_for_job = @industry.jobs.count
    18 end
    19
    20 def company_jobs
    21 @company = Company.find_by(converted_name: params[:converted_name])
    22 @jobs_list = @company.jobs.all_job.page(params[:page]).per(20)
    23 @result_for_job = @company.jobs.count
    24 end
    25
    26 def detail
    27 @job_details = Job.find(params[:id])
    • Van Hau Le @haulv commented Aug 11, 2020
      Master

      @phuocht @jobs = Job.find_by(params[:id]). findvăng exception nếu ko tìm thấy job với id

      @phuocht @jobs = `Job.find_by(params[:id])`. `find`văng exception nếu ko tìm thấy job với id
    Please register or sign in to reply
  • Huỳnh Thiên Phước @phuocht

    closed

    Aug 12, 2020

    closed

    closed
    Toggle commit list
  • Huỳnh Thiên Phước @phuocht

    reopened

    Aug 12, 2020

    reopened

    reopened
    Toggle commit list
  • Huỳnh Thiên Phước @phuocht

    closed

    Aug 13, 2020

    closed

    closed
    Toggle commit list
  • Write
  • Preview
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or sign in to comment
Assignee
No assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
2
2 participants
Reference: phuocht/venjob!5