cover case user not input link to issue

a81ca957 · Tấn Trần Thanh · 05e089e5 · a81ca957
Commit a81ca957 authored Dec 04, 2023 by Tấn Trần Thanh
Hide whitespace changes
Inline Side-by-side

Showing with 7 additions and 5 deletions

plugins/workflow_report/lib/workflow_report.rb
+7 -5

No files found.
--- a/plugins/workflow_report/lib/workflow_report.rb
+++ b/plugins/workflow_report/lib/workflow_report.rb
@@ -97,14 +97,16 @@ module WorkflowReport
        if jp_request.present?
          jp_request = jp_request.strip
          result[32] << jp_request
-          jp_request_arr = URI(jp_request).path.split('/').reject(&:blank?)
+          begin
-          if jp_request_arr.length == 4 && jp_request_arr[3].to_i.positive?
+            jp_request_arr = URI(jp_request).path.split('/').reject(&:blank?)
-            begin
+            if jp_request_arr.length == 4 && jp_request_arr[3].to_i.positive?
              issue_detail = github.issues.find user: jp_request_arr[0], repo: jp_request_arr[1], number: jp_request_arr[3]
              result[33].push(issue_detail.success? ? issue_detail.comments : '')
-            rescue => e
-              result[33].push('')
            end
+          rescue => e
+            p "Error in ISSUE link #{jp_request}"
+            result[33].push('')
          end
        else
          result[32] << ''