added 1 commit

• b571dfef - fix magic number

Compare with previous version

users_by_role.each { |key, _value| users_by_role.delete(key) if key.is_a?(Role) && key.name.in?(%w[Manager JP TeamLead]) }

Nếu rails hiện tại không support in? thì chuyển về include? cho gọn

changed this line in version 3 of the diff

k rõ rails, ruby cũ thì có dùng đc không, thử này đc k @tantt

users_by_role.each do |role, users|
  users.each do |user|
    result << { id: user.id, fullname: "#{user.firstname} #{user.lastname}" } unless LEADER_IDS.include?(user.id)
  end
end

dạ được

changed this line in version 5 of the diff

Này mình lấy từ db ra theo role được không? Sau có thêm, xóa leader đỡ phải update lại plugin.

changed this line in version 3 of the diff

convert to boolean nó có cái này, tham khảo thử:

ActiveModel::Type::Boolean.new.cast 1
=> true

Nhưng a k biết nó support từ rails mấy :D

changed this line in version 3 of the diff

added 1 commit

• b041836a - fix comment and add input select date

Compare with previous version

added 7 commits

• b041836a...aa117c95 - 6 commits from branch feature/search-for-date-and-team-in-plugin-workflow-report
• 45a5d5c6 - merge plugin workflow report

Compare with previous version

changed the description

added 1 commit

• 01ef1b86 - fix comment

Compare with previous version

added 1 commit

• 9cf01390 - fix comment

Compare with previous version

added 1 commit

• 94fcc54e - fix comment

Compare with previous version

resolved all discussions