Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
R
redmine_v2
  • Overview
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 4
    • Merge Requests 4
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • VeNtura
  • redmine_v2
  • Merge Requests
  • !12

Merged
Opened Dec 11, 2023 by Tấn Trần Thanh@tantt 
  • Report abuse
Report abuse

Feature/improve performance workflow report

before 71s

after Screenshot_from_2023-12-13_11-13-47

Edited Dec 13, 2023 by Tấn Trần Thanh
×

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch origin
git checkout -b feature/improve-performance-workflow-report origin/feature/improve-performance-workflow-report

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git checkout hotfix/workflow-report-plugin
git merge --no-ff feature/improve-performance-workflow-report

Step 4. Push the result of the merge to GitLab

git push origin hotfix/workflow-report-plugin

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

  • Discussion 2
  • Commits 10
  • Pipelines 7
  • Changes 6
{{ resolvedDiscussionCount }}/{{ discussionCount }} {{ resolvedCountText }} resolved
  • Tấn Trần Thanh @tantt

    changed the description

    Dec 11, 2023

    changed the description

    changed the description
    Toggle commit list
  • Tấn Trần Thanh @tantt

    changed target branch from master to hotfix/workflow-report-plugin

    Dec 11, 2023

    changed target branch from master to hotfix/workflow-report-plugin

    changed target branch from `master` to `hotfix/workflow-report-plugin`
    Toggle commit list
  • Tấn Trần Thanh @tantt

    added 1 commit

    • 9059d20b - cover some case nil

    Compare with previous version

    Dec 11, 2023

    added 1 commit

    • 9059d20b - cover some case nil

    Compare with previous version

    added 1 commit * 9059d20b - cover some case nil [Compare with previous version](https://gitlab.zigexn.vn/ventura/redmine_v2/merge_requests/12/diffs?diff_id=5599&start_sha=db3cc8864d0c9e5f8fac5749bf2947f1f5cb863a)
    Toggle commit list
  • Hoang Phuc Do
    @phucdh started a discussion on an old version of the diff Dec 11, 2023
    Resolved by Hoang Phuc Do Dec 15, 2023
    plugins/workflow_report/app/models/workflow_report_issue.rb
    2 TESTCASE_FIELD_ID = 22
    3 BUGS_FIELD_ID = 23
    4 STG_BUGS_FIELD_ID = 27
    5 PROD_BUGS_FIELD_ID = 28
    6 PR_FIELD_ID = 18
    7 JP_REQUEST_FIELD_ID = 16
    2 belongs_to :workflow_report_version, class_name: 'Version', foreign_key: 'fixed_version_id'
    3 has_many :workflow_report_custom_values, class_name: 'WorkflowReportCustomValue', foreign_key: 'customized_id'
    8 4
    9 scope :find_root_ids, ->(year, month, project_ids) {
    10 joins(:project, project: :enabled_modules)
    11 .joins('LEFT OUTER JOIN time_entries ON issues.id = time_entries.issue_id')
    12 .where.not(projects: { status: 9 })
    5 scope :raw_tasks_records, -> (year, month, project_ids) {
    6 includes(:project, :workflow_report_version, :workflow_report_custom_values, :time_entries, :status, project: :enabled_modules)
    7 .where.not(projects: { status: 9 }, issues: { tracker_id: 1 })
    • Hoang Phuc Do @phucdh commented Dec 11, 2023
      Developer

      9, 1 are magic numbers. Please replace it with meaningfull names

      `9`, `1` are magic numbers. Please replace it with meaningfull names
    • Tấn Trần Thanh @tantt

      changed this line in version 4 of the diff

      Dec 11, 2023

      changed this line in version 4 of the diff

      changed this line in [version 4 of the diff](https://gitlab.zigexn.vn/ventura/redmine_v2/merge_requests/12/diffs?diff_id=5600&start_sha=9059d20b2019025d076d0c0279f3bc6726673df1#8e10fa652439329e5562dc5498631378b2359a32_7_9)
      Toggle commit list
    Please register or sign in to reply
  • Hoang Phuc Do
    @phucdh started a discussion on an old version of the diff Dec 11, 2023
    Resolved by Hoang Phuc Do Dec 15, 2023
    plugins/workflow_report/lib/workflow_report.rb
    62 60 end
    63 61 pull_request = ''
    64 62 jp_request = ''
    65 record.each do |issue|
    63 issues.each do |issue|
    66 64 if issue.tracker_id == 12
    • Hoang Phuc Do @phucdh commented Dec 11, 2023
      Developer

      issue.tracker_id == 12 -> same as above comment

      `issue.tracker_id == 12` -> same as above comment
    • Tấn Trần Thanh @tantt

      changed this line in version 4 of the diff

      Dec 11, 2023

      changed this line in version 4 of the diff

      changed this line in [version 4 of the diff](https://gitlab.zigexn.vn/ventura/redmine_v2/merge_requests/12/diffs?diff_id=5600&start_sha=9059d20b2019025d076d0c0279f3bc6726673df1#6ba37397caa16cbccf75e776496345d327b7c512_64_66)
      Toggle commit list
    Please register or sign in to reply
  • Tấn Trần Thanh @tantt

    added 1 commit

    • 4164867a - fix comment

    Compare with previous version

    Dec 11, 2023

    added 1 commit

    • 4164867a - fix comment

    Compare with previous version

    added 1 commit * 4164867a - fix comment [Compare with previous version](https://gitlab.zigexn.vn/ventura/redmine_v2/merge_requests/12/diffs?diff_id=5600&start_sha=9059d20b2019025d076d0c0279f3bc6726673df1)
    Toggle commit list
  • Tấn Trần Thanh @tantt

    added 1 commit

    • 4eae780a - multiple thread request to github

    Compare with previous version

    Dec 12, 2023

    added 1 commit

    • 4eae780a - multiple thread request to github

    Compare with previous version

    added 1 commit * 4eae780a - multiple thread request to github [Compare with previous version](https://gitlab.zigexn.vn/ventura/redmine_v2/merge_requests/12/diffs?diff_id=5601&start_sha=4164867aee84d78d191f2fcf4698662178188794)
    Toggle commit list
  • Tấn Trần Thanh @tantt

    changed the description

    Dec 12, 2023

    changed the description

    changed the description
    Toggle commit list
  • Tấn Trần Thanh @tantt

    added 1 commit

    • 6318c7e7 - multiple thread request to github

    Compare with previous version

    Dec 12, 2023

    added 1 commit

    • 6318c7e7 - multiple thread request to github

    Compare with previous version

    added 1 commit * 6318c7e7 - multiple thread request to github [Compare with previous version](https://gitlab.zigexn.vn/ventura/redmine_v2/merge_requests/12/diffs?diff_id=5602&start_sha=4eae780a359f3e1a2e5dd72c60bd78e77b1730b1)
    Toggle commit list
  • Tấn Trần Thanh @tantt

    added 1 commit

    • d70bff1c - better performance

    Compare with previous version

    Dec 13, 2023

    added 1 commit

    • d70bff1c - better performance

    Compare with previous version

    added 1 commit * d70bff1c - better performance [Compare with previous version](https://gitlab.zigexn.vn/ventura/redmine_v2/merge_requests/12/diffs?diff_id=5603&start_sha=6318c7e76cd5c3a5f5f26f5b459319b27c30bc14)
    Toggle commit list
  • Tấn Trần Thanh @tantt

    changed the description

    Dec 13, 2023

    changed the description

    changed the description
    Toggle commit list
  • Hoang Phuc Do @phucdh

    resolved all discussions

    Dec 15, 2023

    resolved all discussions

    resolved all discussions
    Toggle commit list
  • Tấn Trần Thanh @tantt

    added 2 commits

    • 97f51e2f - 1 commit from branch hotfix/workflow-report-plugin
    • 950db87a - Merge branch 'hotfix/workflow-report-plugin' into 'feature/improve-performance-workflow-report'

    Compare with previous version

    Dec 15, 2023

    added 2 commits

    • 97f51e2f - 1 commit from branch hotfix/workflow-report-plugin
    • 950db87a - Merge branch 'hotfix/workflow-report-plugin' into 'feature/improve-performance-workflow-report'

    Compare with previous version

    added 2 commits * 97f51e2f - 1 commit from branch `hotfix/workflow-report-plugin` * 950db87a - Merge branch 'hotfix/workflow-report-plugin' into 'feature/improve-performance-workflow-report' [Compare with previous version](https://gitlab.zigexn.vn/ventura/redmine_v2/merge_requests/12/diffs?diff_id=5604&start_sha=d70bff1cc587d520346aab39af0fa82eadde308e)
    Toggle commit list
  • Tấn Trần Thanh @tantt

    mentioned in commit 5a425a8a

    Dec 15, 2023

    mentioned in commit 5a425a8a

    mentioned in commit 5a425a8a1c6e712fbf1a1ed0cd728bd1cd938d37
    Toggle commit list
  • Tấn Trần Thanh @tantt

    merged

    Dec 15, 2023

    merged

    merged
    Toggle commit list
  • Write
  • Preview
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or sign in to comment
Assignee
No assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
2
2 participants
Reference: ventura/redmine_v2!12
×

Revert this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.
×

Cherry-pick this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.