fix pull comment

app/assets/javascripts/review_comments.coffee

+# Place all the behaviors and hooks related to the matching controller here.
+# All this logic will automatically be available in application.js.
+# You can use CoffeeScript in this file: http://coffeescript.org/

app/assets/stylesheets/review_comments.scss

+// Place all the styles related to the review_comments controller here.
+// They will automatically be included in application.css.
+// You can use Sass (SCSS) here: http://sass-lang.com/

app/controllers/pulls_controller.rb

@@ -16,14 +16,4 @@ class PullsController < ApplicationController
       {id: 2, type: "Medium"},
       {id: 3, type: "Large"}]
   end
-
-  def update
-    if !params[:rv_comment].nil?
-      @rv_comment = ReviewComment.find_by(id: params[:rv_comment][:id])
-      @rv_comment.score = params[:rv_comment][:score]
-      @rv_comment.save
-
-      render json: {comment: @rv_comment.id, score: @rv_comment.score}
-    end
-  end
 end

app/controllers/review_comments_controller.rb

+class ReviewCommentsController < ApplicationController
+
+  def update
+    @rv_comment = ReviewComment.find_by(id: params[:rv_comment][:id])
+    @rv_comment.score = params[:rv_comment][:score]
+    @rv_comment.save
+
+    render json: {comment: @rv_comment.id, score: @rv_comment.score}
+  end
+
+end

app/helpers/review_comments_helper.rb

+module ReviewCommentsHelper
+end

app/views/pulls/show.html.erb

@@ -31,7 +31,7 @@
         </div>
         <div class="panel-body">
           <% @rv_comments.each do |rv_comment| %>
-            <%= form_for :rv_comment, method: :patch, html: { class: "form-inline rate-form" } do |f| %>
+            <%= form_for :rv_comment, url: pull_review_comment_path(pull_id: @pull.id, id: rv_comment.id), method: :patch, html: { class: "form-inline rate-form" } do |f| %>
               <div class="panel panel-default">
                 <%= f.hidden_field "id", value: rv_comment.id %>
                 <div class="panel-heading">
@@ -108,6 +108,7 @@
                     <%= f.submit "Submit", class: "btn btn-default", style: "float: right;" %>
                   </div>
                   <div class="col-md-3" style="float: right;">
+                    <% @comment = OpenStruct.new({ score: 0 }) %>
                     <%= f.select(:score, @options.collect { |x| [ x[:type], x[:id] ] }, {}, { class: 'form-control', style: "float: right;" }) %>
                   </div>
                 </div>
@@ -185,27 +186,25 @@
       });
   });
 
-  $(".btn-save").click(function() {
-    $(".rate-form").submit(function(event) {
-      var submitVar = $(this).serialize();
-      $.ajax({
-        type: "POST",
-        url: $(this).attr("action"),
-        data: submitVar,
-        dataType: "JSON"
-      }).success(function(json) {
-        console.log(json);
-        $.notify({
-          title: "Success!",
-          message: "Comment score changed successfully.",
-        },{
-          type: "success",
-          delay: 100,
-          timer: 1000,
-        });
+  $(".rate-form").submit(function(event) {
+    var submitVar = $(this).serialize();
+    $.ajax({
+      type: "POST",
+      url: $(this).attr("action"),
+      data: submitVar,
+      dataType: "JSON"
+    }).success(function(json) {
+      console.log(json);
+      $.notify({
+        title: "Success!",
+        message: "Comment score changed successfully.",
+      },{
+        type: "success",
+        delay: 100,
+        timer: 1000,
       });
-      return false;
     });
+    return false;
   });
 </script>
 

config/routes.rb

@@ -9,6 +9,7 @@ Rails.application.routes.draw do
   resources :issues
   resources :pulls do
     resources :comments
+    resources :review_comments
   end
   resources :repositories
   resources :comments

github.log

@@ -523,3 +523,8 @@ I, [2017-01-12T14:01:51.798510 #24037]  INFO -- : Insert review comments
 I, [2017-01-12T14:02:25.461132 #24037]  INFO -- : Finished task update in 141.885639132s
 I, [2017-01-12T15:00:04.918096 #28801]  INFO -- : Begin task update ["socialtools", "arubaito-ex", "kuruma-ex", "arubaito_v2"]
 I, [2017-01-12T15:00:04.921609 #28801]  INFO -- : Insert issues
+I, [2017-01-12T16:00:04.085646 #428]  INFO -- : Begin task update ["socialtools", "arubaito-ex", "kuruma-ex", "arubaito_v2"]
+I, [2017-01-12T16:00:04.088863 #428]  INFO -- : Insert issues
+I, [2017-01-12T16:01:26.415292 #428]  INFO -- : Insert comments
+I, [2017-01-12T16:01:52.210615 #428]  INFO -- : Insert review comments
+I, [2017-01-12T16:02:37.067253 #428]  INFO -- : Finished task update in 153.136871445s

test/controllers/review_comments_controller_test.rb

+require 'test_helper'
+
+class ReviewCommentsControllerTest < ActionDispatch::IntegrationTest
+  # test "the truth" do
+  #   assert true
+  # end
+end