Reassigned to @lannn

Reassigned to @giangttd

Reassigned to @lannn

Added 1 commit:

• a29c7bbd - VietTH: Update convention

@vietth in this case, product is an item, right? So, it is not consistent. If "items" change to "products" or all is "item" it will be better meaning

@vietth The code look better if you use "image_tag"

@vietth You can use short way: product equal product_path(product)

@vietth you can use: category equal to category_path(category)

@vietth you can remove "/categories/" because this view is in context of "categories" directory

@vietth typo error: "breadcrumb"

@vietth Is it hard to find these constants? It is better if you have a config file to put these constants. You can use figaro or settinglogic (https://github.com/binarylogic/settingslogic)

@vietth For database integrity. It is good for constraining fields like: t.string :title, null: false

@vietth lack of validations

@vietth lack of validations

Added 1 commit:

• bb3a4f79 - VietTH: Fix review and feedback code

Added 1 commit:

• da86792c - VietTH: Fix review and feedback code

Status changed to merged