Skip to content

V
VietTH-VenShop
Opened by  

VietTH: Feature order management

{{ resolvedDiscussionCount }}/{{ discussionCount }} {{ resolvedCountText }} resolved
  • Tran Hoang Viet @vietth

    Added 6 commits:

    • 1236556d...1cca49df - 4 commits from branch develop
    • f308e16c - Merge remote-tracking branch 'origin/develop' into vietth_feat_order_management
    • 92e948d5 - VietTH: Apply permission to order resource. Use gem cancan

    Added 6 commits:

    • 1236556d...1cca49df - 4 commits from branch develop
    • f308e16c - Merge remote-tracking branch 'origin/develop' into vietth_feat_order_management
    • 92e948d5 - VietTH: Apply permission to order resource. Use gem cancan
    Toggle commit list
  • Nguyen Ngoc Lan
    @lannn started a discussion on an old version of the diff
    Gemfile
    68 68 gem 'draper', '~> 2.1.0'
    69 69  
    70 70 gem 'devise', '~> 3.5.1'
    71 gem 'rolify', '~> 4.0.0'
    72 gem 'cancan', '~> 1.6.10'
    Please register or sign in to reply
  • Nguyen Ngoc Lan
    @lannn started a discussion on an old version of the diff
    app/controllers/orders_controller.rb
    19 22 end
    20 23 end
    21 24  
    25 def management
    • Nguyen Ngoc Lan @lannn commented
      Developer

      @vietth Để dễ kiểm soát và phân biệt actions thì nên move action management này vào namespace

      Với user là admin thì sẽ là admin thì admin/orders_controller.rb action là index, còn là user thông thường có thể là user/orders_controller

      http://stackoverflow.com/questions/16444489/create-administration-area-in-rails-app

      Edited
    Please register or sign in to reply
  • Tran Hoang Viet
    @vietth started a discussion on an old version of the diff
    app/controllers/orders_controller.rb
    19 22 end
    20 23 end
    21 24  
    25 def management
    • Tran Hoang Viet @vietth commented
      Master

      Okie. Mà feature này viết nữa chừng thì bỏ rồi không viết nữa, thấy nó chỉ là CRUD nên đang tập trung những feature khác như search multi fields, S3 ...

    Please register or sign in to reply
  • Tran Hoang Viet
    @vietth started a discussion on an old version of the diff
    Gemfile
    68 68 gem 'draper', '~> 2.1.0'
    69 69  
    70 70 gem 'devise', '~> 3.5.1'
    71 gem 'rolify', '~> 4.0.0'
    72 gem 'cancan', '~> 1.6.10'
    Please register or sign in to reply
  • Tran Hoang Viet @vietth

    Added 2 commits:

    • e6026430 - VietTH: Use gem pundit instead cancan
    • bae6f988 - VietTH: Fix review code, saperate admin orders controler

    Added 2 commits:

    • e6026430 - VietTH: Use gem pundit instead cancan
    • bae6f988 - VietTH: Fix review code, saperate admin orders controler
    Toggle commit list
  • Truong Ba Dieu
    @dieutb started a discussion on the diff
    app/controllers/orders_controller.rb
    1 1 class OrdersController < ApplicationController
    2 2 before_action :authenticate_user!
    3 before_action :set_order, only: [:show, :update]
    4 before_action -> { authorize(@order) }, only: [:show, :update]
    Please register or sign in to reply
  • Truong Ba Dieu
    @dieutb started a discussion on the diff
    app/views/layouts/application.html.haml
    9 9 %body
    10 10 %nav.navbar.navbar-inverse.navbar-fixed-top
    11 11 .container-fluid
    12 = render 'layouts/header'
    12 = render '/layouts/header'
    Please register or sign in to reply
  • Truong Ba Dieu
    @dieutb started a discussion on the diff
    app/views/orders/index.html.haml
    4 .order-item.table-responsive
    6 5 %table.table
    7 6 %thead
    8 7 %tr
    9 8 %td.text-right #
    10 %td Title
    11 %td Price
    12 %td Stock
    13 %td Quantity
    9 %td Order number
    10 / %td Ordered by
    11 %td Created at
    12 %td Status
    14 13 %tbody
    15 - current_user.cart.items.each_with_index do |order_item, index|
    14 - @orders.each_with_index do |order_item, index|
    Please register or sign in to reply
  • Tran Hoang Viet
    @vietth started a discussion on the diff
    app/controllers/orders_controller.rb
    1 1 class OrdersController < ApplicationController
    2 2 before_action :authenticate_user!
    3 before_action :set_order, only: [:show, :update]
    4 before_action -> { authorize(@order) }, only: [:show, :update]
    Please register or sign in to reply
  • Tran Hoang Viet
    @vietth started a discussion on the diff
    app/views/layouts/application.html.haml
    9 9 %body
    10 10 %nav.navbar.navbar-inverse.navbar-fixed-top
    11 11 .container-fluid
    12 = render 'layouts/header'
    12 = render '/layouts/header'
    Please register or sign in to reply
  • Tran Hoang Viet
    @vietth started a discussion on the diff
    app/views/orders/index.html.haml
    4 .order-item.table-responsive
    6 5 %table.table
    7 6 %thead
    8 7 %tr
    9 8 %td.text-right #
    10 %td Title
    11 %td Price
    12 %td Stock
    13 %td Quantity
    9 %td Order number
    10 / %td Ordered by
    11 %td Created at
    12 %td Status
    14 13 %tbody
    15 - current_user.cart.items.each_with_index do |order_item, index|
    14 - @orders.each_with_index do |order_item, index|
    • Tran Hoang Viet @vietth commented
      Master

      Order duoc show duoi dang tag <tr><td> ma dua vao partial thi co ve k hop ly lam, partial thuong dung de render detail cua 1 object. Voi lai hien tai khong co nhieu cho show list order.

    Please register or sign in to reply
  • Truong Ba Dieu
    @dieutb started a discussion on the diff
    app/views/orders/index.html.haml
    4 .order-item.table-responsive
    6 5 %table.table
    7 6 %thead
    8 7 %tr
    9 8 %td.text-right #
    10 %td Title
    11 %td Price
    12 %td Stock
    13 %td Quantity
    9 %td Order number
    10 / %td Ordered by
    11 %td Created at
    12 %td Status
    14 13 %tbody
    15 - current_user.cart.items.each_with_index do |order_item, index|
    14 - @orders.each_with_index do |order_item, index|
    Please register or sign in to reply
  • Truong Ba Dieu
    @dieutb started a discussion on the diff
    app/views/layouts/application.html.haml
    9 9 %body
    10 10 %nav.navbar.navbar-inverse.navbar-fixed-top
    11 11 .container-fluid
    12 = render 'layouts/header'
    12 = render '/layouts/header'
    Please register or sign in to reply
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment