Skip to content

V
VietTH-VenShop
Opened by  

VietTH: Feature search

{{ resolvedDiscussionCount }}/{{ discussionCount }} {{ resolvedCountText }} resolved
  • Nguyen Ngoc Lan
    @lannn started a discussion on an old version of the diff
    app/controllers/categories_controller.rb 0 → 100644
    1 class CategoriesController < ApplicationController
    2 before_action :set_category, only: [:show]
    3
    4 def show
    5 @products = @category.products.page(params[:page])
    6 end
    7
    8 private
    9 def set_category
    10 @category = Category.find_by(id: params[:id])
    11 redirect_to root_path, alert: "Category not found" if @category.blank?
    • Nguyen Ngoc Lan @lannn commented
      Developer

      @vietth There are some models which you also have to rescue like: product, category,....

      There is a better way to rescue by raising error and rescue at ApplicationController

      Use Category.find to raise error. Please see example below:

      http://stackoverflow.com/questions/2336593/rescue-from-activerecordrecordnotfound-in-rails

    Please register or sign in to reply
  • Tran Hoang Viet
    @vietth started a discussion on an old version of the diff
    app/controllers/categories_controller.rb 0 → 100644
    1 class CategoriesController < ApplicationController
    2 before_action :set_category, only: [:show]
    3
    4 def show
    5 @products = @category.products.page(params[:page])
    6 end
    7
    8 private
    9 def set_category
    10 @category = Category.find_by(id: params[:id])
    11 redirect_to root_path, alert: "Category not found" if @category.blank?
    Please register or sign in to reply
  • Tran Hoang Viet @vietth

    Added 6 commits:

    • f09632a0 - VietTH: Implement rspec test for model
    • dc7a3a6d - Initialize library to deploy
    • e6e8a16c - VietTH: Apply rubocop
    • 97dbc504 - VietTH: Update info for deploy
    • 5a3bd5d8 - VietTH: Update info for deploy
    • 26aab3c8 - VietTH: Fix review code feature search

    Added 6 commits:

    • f09632a0 - VietTH: Implement rspec test for model
    • dc7a3a6d - Initialize library to deploy
    • e6e8a16c - VietTH: Apply rubocop
    • 97dbc504 - VietTH: Update info for deploy
    • 5a3bd5d8 - VietTH: Update info for deploy
    • 26aab3c8 - VietTH: Fix review code feature search
    Toggle commit list
  • Tran Hoang Viet @vietth

    Status changed to merged

    Status changed to merged

    Toggle commit list
  • Tran Hoang Viet @vietth

    mentioned in commit 3b19a49d

    mentioned in commit 3b19a49d

    Toggle commit list
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment