Skip to content

V
VietTH-VenShop
Opened by  

VietTH: Feature stock management

{{ resolvedDiscussionCount }}/{{ discussionCount }} {{ resolvedCountText }} resolved
  • Nguyen Ngoc Lan
    @lannn started a discussion on an old version of the diff
    app/services/order_service.rb
    1 1 class OrderService < BaseService
    2 2  
    3 def create(order_params)
    4 order = current_user.orders.build(order_params)
    5
    6 product_ids = []
    7 quantites = {}
    8 order_params['order_items_attributes'].each do |item|
    9 id = item.last['product_id']
    10 product_ids << id
    11 quantites[id] = item.last['quantity']
    12 end
    3 def add_to_cart product
    • Nguyen Ngoc Lan @lannn commented
      Developer

      @vietth lack of () for argument. It makes recognize argument easier. And this is order service and you put cart functionality in here, is it right place?

      This violates single responsibility

      If you can find out other appropriate place for add_to_cart method, code will be better

      Edited
    Please register or sign in to reply
  • Nguyen Ngoc Lan
    @lannn started a discussion on an old version of the diff
    app/controllers/products_controller.rb
    26 24 end
    27 25  
    28 26 def add_cart
    29 add_to_cart(@product)
    30 redirect_to(@product, notice: 'Product is added to cart.')
    27 result = order_service.add_to_cart(@product)
    Please register or sign in to reply
  • Nguyen Ngoc Lan
    @lannn started a discussion on an old version of the diff
    app/models/order_item.rb
    1 1 class OrderItem < ActiveRecord::Base
    2 2 belongs_to :order
    3 3 belongs_to :product
    4
    5 before_save :update_product_quantity
    Please register or sign in to reply
  • Tran Hoang Viet
    @vietth started a discussion on an old version of the diff
    app/services/order_service.rb
    1 1 class OrderService < BaseService
    2 2  
    3 def create(order_params)
    4 order = current_user.orders.build(order_params)
    5
    6 product_ids = []
    7 quantites = {}
    8 order_params['order_items_attributes'].each do |item|
    9 id = item.last['product_id']
    10 product_ids << id
    11 quantites[id] = item.last['quantity']
    12 end
    3 def add_to_cart product
    Please register or sign in to reply
  • Tran Hoang Viet
    @vietth started a discussion on an old version of the diff
    app/models/order_item.rb
    1 1 class OrderItem < ActiveRecord::Base
    2 2 belongs_to :order
    3 3 belongs_to :product
    4
    5 before_save :update_product_quantity
    Please register or sign in to reply
  • Tran Hoang Viet
    @vietth started a discussion on an old version of the diff
    app/controllers/products_controller.rb
    26 24 end
    27 25  
    28 26 def add_cart
    29 add_to_cart(@product)
    30 redirect_to(@product, notice: 'Product is added to cart.')
    27 result = order_service.add_to_cart(@product)
    • Tran Hoang Viet @vietth commented
      Master

      @lannn Currently, 'add_to_cart' and methods in service are returned a hash {status: STATUS}. In cases i have many exception, I can return it with {status: false, error: ERROR_CODE}. Then I can easily control errors which are returned.

      Edited
    Please register or sign in to reply
  • Nguyen Ngoc Lan
    @lannn started a discussion on an old version of the diff
    app/models/order_item.rb
    1 1 class OrderItem < ActiveRecord::Base
    2 2 belongs_to :order
    3 3 belongs_to :product
    4
    5 before_save :update_product_quantity
    Please register or sign in to reply
  • Nguyen Ngoc Lan
    @lannn started a discussion on an old version of the diff
    app/services/order_service.rb
    1 1 class OrderService < BaseService
    2 2  
    3 def create(order_params)
    4 order = current_user.orders.build(order_params)
    5
    6 product_ids = []
    7 quantites = {}
    8 order_params['order_items_attributes'].each do |item|
    9 id = item.last['product_id']
    10 product_ids << id
    11 quantites[id] = item.last['quantity']
    12 end
    3 def add_to_cart product
    Please register or sign in to reply
  • Nguyen Ngoc Lan
    @lannn started a discussion on an old version of the diff
    app/controllers/products_controller.rb
    26 24 end
    27 25  
    28 26 def add_cart
    29 add_to_cart(@product)
    30 redirect_to(@product, notice: 'Product is added to cart.')
    27 result = order_service.add_to_cart(@product)
    • Nguyen Ngoc Lan @lannn commented
      Developer

      You have reason! I agree to return { status: false, error: ERROR_CODE } in service. Please add space after { and before }. It looks more spacious to read code

    Please register or sign in to reply
  • Tran Hoang Viet @vietth

    Added 1 commit:

    • 91759019 - VietTH: Move add_t_cart and update_cart to CartService

    Added 1 commit:

    • 91759019 - VietTH: Move add_t_cart and update_cart to CartService
    Toggle commit list
  • Tran Hoang Viet @vietth

    Added 1 commit:

    • d95632a4 - VietTH: Implement validate add_to_cart

    Added 1 commit:

    • d95632a4 - VietTH: Implement validate add_to_cart
    Toggle commit list
  • Tran Hoang Viet @vietth

    Added 1 commit:

    • ceb74a0c - VietTH: Create new product with new attribute :stock

    Added 1 commit:

    • ceb74a0c - VietTH: Create new product with new attribute :stock
    Toggle commit list
  • Tran Hoang Viet @vietth

    Status changed to merged

    Status changed to merged

    Toggle commit list
  • Tran Hoang Viet @vietth

    mentioned in commit f04cca90

    mentioned in commit f04cca90

    Toggle commit list
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment