Add job apply
{{ resolvedDiscussionCount }}/{{ discussionCount }} {{ resolvedCountText }} resolved
-
app/controllers/entries_controller.rb 0 → 10064423 end 24 25 # GET /entries/1/edit 26 def edit; end 27 28 # POST /entries 29 # POST /entries.json 30 def create 31 @entry = Entry.new(entry_params) 32 33 @job = Job.find(params[:job_id]) 34 35 @user = User.find_by(email: params[:entry][:entry_email]) || 36 User.create(name: params[:entry][:entry_name], 37 email: params[:entry][:entry_email], 38 password: 'password', -
Master
use SecureRandom to generate password
-
-
-
app/controllers/entries_controller.rb 0 → 100644
3 class EntriesController < ApplicationController 4 before_action :set_entry, only: [:show, :edit, :update, :destroy] 5 6 # GET /entries 7 # GET /entries.json 8 def index 9 @entries = Entry.all 10 end 11 12 # GET /entries/1 13 # GET /entries/1.json 14 def show; end 15 16 # GET /entries/new 17 def new 18 if params[:entry_name].blank? && params[:entry_email] -
Master
do we need if/else here?
-
-
-
app/controllers/entries_controller.rb 0 → 100644
32 33 @job = Job.find(params[:job_id]) 34 35 @user = User.find_by(email: params[:entry][:entry_email]) || 36 User.create(name: params[:entry][:entry_name], 37 email: params[:entry][:entry_email], 38 password: 'password', 39 password_confirmation: 'password') 40 41 @entry.user_id = @user.id 42 @entry.job_id = @job.id 43 44 if @user.jobs.include?(@job) 45 # redirect_to job_url(@job), notice: 'You has been entry this job.' 46 redirect_to job_url(@job), flash: { secondary: 'You has been entry this job.' } 47 elsif -
Master
what condition for elsif?
-
-
-
app/controllers/entries_controller.rb 0 → 100644
55 end 56 57 # PATCH/PUT /entries/1 58 # PATCH/PUT /entries/1.json 59 def update 60 if @entry.update(entry_params) 61 redirect_to @entry, notice: 'Entry was successfully updated.' 62 else 63 render :edit 64 end 65 end 66 67 # DELETE /entries/1 68 # DELETE /entries/1.json 69 def destroy 70 @entry.destroy -
Master
we don't need destroy for end-user here
-
-
-
11 11 dependent: :destroy 12 12 has_many :industries, through: :industries_jobs 13 13 14 has_many :entries, foreign_key: 'job_id', -
Master
-
Master
has_many entries, foreign_key job_id, please check again
-
-
-
11 11 dependent: :destroy 12 12 has_many :industries, through: :industries_jobs 13 13 14 has_many :entries, foreign_key: 'job_id', 15 dependent: :destroy 16 has_many :users, through: :entries 17 14 18 has_many :entries, dependent: :destroy 15 19 has_many :favorite_jobs, dependent: :destroy -
Master
why jobs has favorite jobs?
-
-
-
2 2 # Include default devise modules. Others available are: 3 3 # :confirmable, :lockable, :timeoutable and :omniauthable 4 4 devise :database_authenticatable, :registerable, 5 :recoverable, :rememberable, :trackable, :validatable, 5 :recoverable, :rememberable, :validatable, 6 6 :confirmable 7 7 8 8 has_many :entries, dependent: :destroy 9 9 has_many :favorite_jobs, dependent: :destroy 10 10 11 has_many :entries, foreign_key: 'user_id', -
Master
when user being delete, entry will being delete too
-
-
app/views/entries/_form.html.erb 0 → 100644
5 6 <ul> 7 <% entry.errors.full_messages.each do |message| %> 8 <li><%= message %></li> 9 <% end %> 10 </ul> 11 </div> 12 <% end %> 13 14 <%= hidden_field_tag :job_id, @job.id %> 15 16 <%= form.label :name %><br> 17 <%= form.text_field :entry_name, class: 'form-control col-sm-4' %><br> 18 19 <%= form.label :email %><br> 20 <%= form.email_field :entry_email, class: 'form-control col-sm-4' %><br> -
Master
please add more field such as phone number, address, we need to contact them
-
-
-
app/views/entries/index.html.erb 0 → 100644
1 <p id="notice"><%= notice %></p> -
Master
we don't need this view
-
-
-
10 10 <p> 11 11 <%= @job.description %> 12 12 </p> 13 14 <% if user_signed_in? %> 15 <%= link_to "Apply", { controller: "entries", action: "new", job_id: @job.id, 16 entry_name: current_user.name, entry_email: current_user.email }, 17 class: "btn btn-secondary" %> 18 <% else %> 19 <%= link_to "Apply", apply_path(job_id: @job.id), 20 class: "btn btn-secondary" %> -
Master
you don't need to do that, you can get current_user.name on entries_controller
-
-
-
app/views/user_mailer/job_apply.html.erb 0 → 100644
1 <p>Dear <%= @user.name %></p> 2 3 <p>Job title: <%= @job.title %></p> 4 <p>Location: <%= @job.cities.first.name %></p> 5 <p>Company: <%= Company.find(@job.company_id).name %></p> -
Master
you can use @job.company.name
-
-
-
app/views/user_mailer/job_apply.html.erb 0 → 100644
1 <p>Dear <%= @user.name %></p> 2 3 <p>Job title: <%= @job.title %></p> 4 <p>Location: <%= @job.cities.first.name %></p> 5 <p>Company: <%= Company.find(@job.company_id).name %></p> -
Master
you can use @job.company.name
-
-
-
added 2 commits
Toggle commit list -
app/controllers/entries_controller.rb 0 → 100644
15 entry_email: current_user.email, 16 entry_phone: current_user.phone, 17 entry_address: current_user.address) 18 else 19 Entry.new 20 end 21 end 22 23 # POST /entries 24 # POST /entries.json 25 def create 26 @entry = Entry.new(entry_params) 27 28 @job = Job.find(params[:job_id]) 29 30 random_password = Devise.friendly_token -
MasterEdited by Van Toan Vu
random_password need only when create new user, when you don't need it don't call it
-
-
-
Toggle commit list
-
merged
Toggle commit list
